Skip to content

[video_player_avplay/videohole] Remove unused proxy apis #961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JSUYA merged 3 commits into from
Feb 5, 2026
Merged

[video_player_avplay/videohole] Remove unused proxy apis #961

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7bf4644
[video_player_avplay/videohole] Remove unused proxy apis
JSUYA Feb 5, 2026
c831001
++
JSUYA Feb 5, 2026
0eb4e88
Merge branch 'master' into remove_unused_ecore_api
JSUYA Feb 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/video_player_avplay/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
## NEXT

* Adds compatibility with `http` 1.0 in example.
* Removed unused proxy APIs.

## 0.8.1

Expand Down
16 changes: 0 additions & 16 deletions packages/video_player_avplay/tizen/src/ecore_wl2_window_proxy.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@

typedef void (*FuncEcoreWl2WindowGeometryGet)(void *window, int *x, int *y,
int *width, int *height);
typedef int (*FuncEcoreWl2WindowSurfaceIdGet)(void *window);

EcoreWl2WindowProxy::EcoreWl2WindowProxy() {
ecore_wl2_window_handle_ = dlopen("libecore_wl2.so.1", RTLD_LAZY);
Expand All @@ -37,21 +36,6 @@ void EcoreWl2WindowProxy::ecore_wl2_window_geometry_get(void *window, int *x,
ecore_wl2_window_geometry_get(window, x, y, width, height);
}

int EcoreWl2WindowProxy::ecore_wl2_window_surface_id_get(void *window) {
if (!ecore_wl2_window_handle_) {
LOG_ERROR("ecore_wl2_window_handle_ not valid");
return -1;
}
FuncEcoreWl2WindowSurfaceIdGet ecore_wl2_window_surface_id_get =
reinterpret_cast<FuncEcoreWl2WindowSurfaceIdGet>(
dlsym(ecore_wl2_window_handle_, "ecore_wl2_window_surface_id_get"));
if (!ecore_wl2_window_surface_id_get) {
LOG_ERROR("Fail to find ecore_wl2_window_surface_id_get.");
return -1;
}
return ecore_wl2_window_surface_id_get(window);
}

EcoreWl2WindowProxy::~EcoreWl2WindowProxy() {
if (ecore_wl2_window_handle_) {
dlclose(ecore_wl2_window_handle_);
Expand Down
1 change: 0 additions & 1 deletion packages/video_player_avplay/tizen/src/ecore_wl2_window_proxy.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ class EcoreWl2WindowProxy {
~EcoreWl2WindowProxy();
void ecore_wl2_window_geometry_get(void *window, int *x, int *y, int *width,
int *height);
int ecore_wl2_window_surface_id_get(void *window);

private:
void *ecore_wl2_window_handle_ = nullptr;
Expand Down
1 change: 1 addition & 0 deletions packages/video_player_videohole/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
## NEXT

* Adds compatibility with `http` 1.0 in example.
* Removed unused proxy APIs.

## 0.5.8

Expand Down
16 changes: 0 additions & 16 deletions packages/video_player_videohole/tizen/src/ecore_wl2_window_proxy.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@

typedef void (*FuncEcoreWl2WindowGeometryGet)(void *window, int *x, int *y,
int *width, int *height);
typedef int (*FuncEcoreWl2WindowSurfaceIdGet)(void *window);

EcoreWl2WindowProxy::EcoreWl2WindowProxy() {
ecore_wl2_window_handle_ = dlopen("libecore_wl2.so.1", RTLD_LAZY);
Expand All @@ -37,21 +36,6 @@ void EcoreWl2WindowProxy::ecore_wl2_window_geometry_get(void *window, int *x,
ecore_wl2_window_geometry_get(window, x, y, width, height);
}

int EcoreWl2WindowProxy::ecore_wl2_window_surface_id_get(void *window) {
if (!ecore_wl2_window_handle_) {
LOG_ERROR("ecore_wl2_window_handle_ not valid");
return -1;
}
FuncEcoreWl2WindowSurfaceIdGet ecore_wl2_window_surface_id_get =
reinterpret_cast<FuncEcoreWl2WindowSurfaceIdGet>(
dlsym(ecore_wl2_window_handle_, "ecore_wl2_window_surface_id_get"));
if (!ecore_wl2_window_surface_id_get) {
LOG_ERROR("Fail to find ecore_wl2_window_surface_id_get.");
return -1;
}
return ecore_wl2_window_surface_id_get(window);
}

EcoreWl2WindowProxy::~EcoreWl2WindowProxy() {
if (ecore_wl2_window_handle_) {
dlclose(ecore_wl2_window_handle_);
Expand Down
1 change: 0 additions & 1 deletion packages/video_player_videohole/tizen/src/ecore_wl2_window_proxy.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ class EcoreWl2WindowProxy {
~EcoreWl2WindowProxy();
void ecore_wl2_window_geometry_get(void *window, int *x, int *y, int *width,
int *height);
int ecore_wl2_window_surface_id_get(void *window);

private:
void *ecore_wl2_window_handle_ = nullptr;
Expand Down
Loading