Fix/issue 186 dispose cancel#196
Open
apravint wants to merge 4 commits into
Open
Conversation
… setState on disposed widget This fix addresses flutter#186 by properly canceling both _pendingPromptResponse and _pendingSttResponse when the widget is disposed. Previously, when users navigated away while the LLM was streaming a response, the widget would crash with "Null check operator used on a null value" because dispose() didn't cancel the pending response, allowing the onUpdate callback to call setState() on a disposed widget. Changes: - Added _pendingPromptResponse?.cancel() in dispose() - Added _pendingSttResponse?.cancel() in dispose() - Moved super.dispose() to the end to ensure cleanup happens before widget disposal Impact: Fixes crash affecting 588 occurrences across 124 production users
Contributor
Author
|
The fix adds the missing cancel() calls for both _pendingPromptResponse and _pendingSttResponse in the dispose() method to prevent setState on disposed widget. The implementation:
This directly addresses the 588 occurrences affecting 124 users you reported. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #186 - Prevents crash when users navigate away while LLM is streaming a response.
When a user navigates away from
LlmChatViewwhile the LLM is still streaming a response, the widget crashes withNull check operator used on a null value. This happens because thedispose()method doesn't cancel pending responses, allowing theonUpdatecallback to callsetState()on a disposed widget.Changes
_pendingPromptResponse?.cancel()indispose()_pendingSttResponse?.cancel()indispose()super.dispose()to the end to ensure proper cleanup orderImpact
This fix resolves crashes affecting 588 occurrences across 124 production users in production apps using
flutter_ai_toolkit1.0.0.Pre-launch Checklist