Skip to content

176990 Implement get presubmit guard api#4940

Merged
auto-submit[bot] merged 17 commits intoflutter:mainfrom
ievdokdm:176990-api
Feb 9, 2026
Merged

176990 Implement get presubmit guard api#4940
auto-submit[bot] merged 17 commits intoflutter:mainfrom
ievdokdm:176990-api

Conversation

@ievdokdm
Copy link
Contributor

@ievdokdm ievdokdm commented Feb 4, 2026

Implement get presubmit guard api

Partial Fix: flutter/flutter#176990

@ievdokdm ievdokdm requested a review from jtmcdole February 4, 2026 23:47
Task: Implement get presubmit guard api
Summary: Implemented a new API endpoint /api/get-presubmit-guard to serve consolidated presubmit guard statuses.
Files:
- app_dart/lib/server.dart: Registered the new endpoint.
- app_dart/lib/src/request_handlers/get_presubmit_guard.dart: Implemented the request handler.
- app_dart/lib/src/service/firestore.dart: Added queryPresubmitGuards method.
- app_dart/test/request_handlers/get_presubmit_guard_test.dart: Added unit tests for the handler.
- app_dart/test/service/presubmit_guard_query_test.dart: Added unit tests for the firestore query.
- app_dart/test/src/utilities/entity_generators.dart: Added PresubmitGuard generator for tests.
- packages/cocoon_common/lib/rpc_model.dart: Exported new DTO.
- packages/cocoon_common/lib/src/rpc_model/presubmit_guard.dart: Defined response DTO.
- packages/cocoon_common/lib/src/rpc_model/presubmit_guard.g.dart: Generated JSON serialization code.
Why: Provides the dashboard with real-time visibility into presubmit checks.
Copy link
Member

@jtmcdole jtmcdole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some feedback -

…add documentation to presubmit guard RPC models, and improve error handling in `GetPresubmitGuard`.
@ievdokdm
Copy link
Contributor Author

ievdokdm commented Feb 6, 2026

resolved comments

…enaming and remove redundant JsonKey annotations.
@ievdokdm ievdokdm added the autosubmit Merge PR when tree becomes green via auto submit App. label Feb 7, 2026
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App. label Feb 7, 2026
@auto-submit
Copy link
Contributor

auto-submit bot commented Feb 7, 2026

autosubmit label was removed for flutter/cocoon/4940, because - The status or check suite test-app-dart has failed. Please fix the issues identified (or deflake) before re-applying this label.

@ievdokdm ievdokdm added the autosubmit Merge PR when tree becomes green via auto submit App. label Feb 9, 2026
@auto-submit auto-submit bot merged commit cee97b3 into flutter:main Feb 9, 2026
19 checks passed
@ievdokdm ievdokdm deleted the 176990-api branch February 11, 2026 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement Dashboard back-end for LUCI Tests statuses

2 participants