Add build number for re-run failed jobs#4948
Merged
auto-submit[bot] merged 15 commits intoflutter:mainfrom Feb 13, 2026
Merged
Conversation
Task: Update PresubmitCheckState Model Summary: Added buildNumber to PresubmitCheckState and mapped it from the LUCI build in the BuildToPresubmitCheckState extension. Files: app_dart/lib/src/model/common/presubmit_check_state.dart, app_dart/test/model/common/presubmit_check_state_test.dart Why: To allow tracking of the LUCI build number throughout the presubmit check processing lifecycle.
Task: Update PresubmitCheck Firestore Model Summary: Added buildNumber setter and unit tests to the PresubmitCheck Firestore model. Files: app_dart/lib/src/model/firestore/presubmit_check.dart, app_dart/test/model/firestore/presubmit_check_test.dart Why: To enable storing and retrieving the LUCI build number in Firestore for each presubmit check attempt.
Task: Update PresubmitCheckResponse RPC Model Summary: Added buildNumber to PresubmitCheckResponse and configured JSON serialization to omit null fields. Files: packages/cocoon_common/lib/src/rpc_model/presubmit_check_response.dart, packages/cocoon_common/lib/src/rpc_model/presubmit_check_response.g.dart, packages/cocoon_common/test/presubmit_check_response_test.dart Why: To expose the LUCI build number in the API responses for presubmit checks.
Task: Update UnifiedCheckRun.markConclusion Logic Summary: Updated markConclusion to store the buildNumber from PresubmitCheckState into the Firestore PresubmitCheck document. Updated relevant tests. Files: app_dart/lib/src/service/firestore/unified_check_run.dart, app_dart/test/service/firestore/unified_check_run_test.dart Why: To ensure the LUCI build number is persisted in Firestore when a presubmit check completes.
Task: Update GetPresubmitChecks API Handler Summary: Updated the GetPresubmitChecks API handler to include the buildNumber from the Firestore PresubmitCheck document in the PresubmitCheckResponse. Updated relevant tests. Files: app_dart/lib/src/request_handlers/get_presubmit_checks.dart, app_dart/test/request_handlers/get_presubmit_checks_test.dart Why: To expose the LUCI build number in the API for consumption by the dashboard.
…eck and fill it on processing checkrun completed' as complete
…tCheck and fill it on processing checkrun completed'
ievdokdm
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
Contributor
|
autosubmit label was removed for flutter/cocoon/4948, because Pull request flutter/cocoon/4948 is not in a mergeable state. |
ievdokdm
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
Contributor
|
autosubmit label was removed for flutter/cocoon/4948, because - The status or check suite common-validations has failed. Please fix the issues identified (or deflake) before re-applying this label. |
ievdokdm
added
the
autosubmit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add build number for re-run failed jobs
Partial Fix: flutter/flutter#176990