Fixes null error when parsing universal link settings #9581
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chunhtai
commented
Dec 11, 2025
| }); | ||
|
|
||
| test('handles missing associatedDomains', () { | ||
| // This might crash based on my reading of the code, but let's see. |
Contributor
Author
There was a problem hiding this comment.
lol gemini what the hack is this
elliette
reviewed
Dec 12, 2025
packages/devtools_shared/test/deeplink/universal_link_settings_test.dart
Outdated
Show resolved
Hide resolved
elliette
approved these changes
Dec 12, 2025
Member
elliette
left a comment
elliette
left a comment
There was a problem hiding this comment.
Small change but otherwise LGTM! Thanks for the fix
chunhtai
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
|
autosubmit label was removed for flutter/devtools/9581, because - The status or check suite macos-latest devtools_app integration-test integration_dart2js - flutter-web - shard 2/2 has failed. Please fix the issues identified (or deflake) before re-applying this label. |
chunhtai
added
the
autosubmit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #8972
it is possible the tool can't get team id from the xcode project if the xcode developer team is not properly set up. In that case it will be null in the universal link setting's json. This Pr handles that cases
Pre-launch Checklist
///).If you need help, consider asking for help on Discord.