rfc21: add clarification on multiple exceptions#492
rfc21: add clarification on multiple exceptions#492mergify[bot] merged 1 commit intoflux-framework:masterfrom
Conversation
spec_21.rst
Outdated
| More than one exception MAY occur per job. At most one exception of | ||
| severity zero SHOULD occur. If more than one exception of severity zero | ||
| occurs, the first one SHALL be considered the most severe exception for | ||
| reporting purposes. |
There was a problem hiding this comment.
I think multiple exceptions aren't really that extraordinary so I would probably relax this a bit and also I would probably use different phrase than "most severe". Would this work?
More than one exception MAY occur per job. If more than one exception of severity
zero occurs, the first one SHALL be considered the root cause of the job failure for reporting purposes.
There was a problem hiding this comment.
I like the idea of using the term "root cause".
chu11
force-pushed
the
spec21_extra_exceptions
branch
from
b48db79 to
fc82a69
Compare
|
re-pushed, tweaking with suggested change |
|
|
Problem: RFC21 implies that the first exception of severity 0 is the root cause exception because it is the one that transitions a job state to CLEANUP. However, it is not explicitly stated. Add some additional language that notes that if multiple exceptions of severity 0 occur, the first one is the root cause for reporting purposes.
chu11
force-pushed
the
spec21_extra_exceptions
branch
from
fc82a69 to
eea237b
Compare
|
|
1 similar comment
|
|
Merge Queue Status✅ The pull request has been merged at eea237b This pull request spent 10 seconds in the queue, with no time running CI. Required conditions to merge
|
2 participants
Problem: RFC21 implies that the first exception of severity 0 is the "most severe" exception because it is the one that transitions a job state to CLEANUP. However, it is not explicitly stated.
Add some additional language that notes that if multiple exceptions of severity 0 occur, the first one is considered the "most severe" for reporting purposes.
Just a minor thing I noticed, as I began thinking of work on job-sql database stuff.