Add Drifted condition to HelmRelease
#1367
Open
+235
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yozel
changed the title
Drifted conditionDrifted condition to HelmRelease and log generation
yozel
force-pushed
the
yozel/add-drifted-condition
branch
3 times, most recently
from
7f9cf56 to
e10328c
Compare
yozel
force-pushed
the
yozel/add-drifted-condition
branch
from
e10328c to
238ebbe
Compare
yozel
changed the title
Drifted condition to HelmRelease and log generationDrifted condition to HelmRelease
yozel
force-pushed
the
yozel/add-drifted-condition
branch
from
238ebbe to
627159a
Compare
matheuscscp
reviewed
Jan 8, 2026
yozel
force-pushed
the
yozel/add-drifted-condition
branch
from
627159a to
c7d9ebf
Compare
Member
|
It would be nice to add a test for when the condition is false |
yozel
force-pushed
the
yozel/add-drifted-condition
branch
from
c7d9ebf to
fb7ed67
Compare
Contributor
Author
I'll add it right now |
yozel
force-pushed
the
yozel/add-drifted-condition
branch
from
fb7ed67 to
0d71cdf
Compare
stefanprodan
reviewed
Jan 9, 2026
Comment on lines
+388
to
+396
| if req.Object.GetDriftDetection().MustDetectChanges() { | ||
| conditions.MarkFalse(req.Object, v2.DriftedCondition, v2.NoDriftDetectedReason, "No drift detected against the cluster state") | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
Shouldn't we remove this condition if drift is not enabled in spec?
Member
There was a problem hiding this comment.
Maybe put an else to remove the condition if MustDetectChanges() returns false?
Contributor
Author
There was a problem hiding this comment.
@stefanprodan good point.
@matheuscscp then it would not be removed in case release state is not InSync. I can remove the condition in the beginning of AtomicRelease.actionForState here or even in AtomicRelease.Reconcile here, so we can be sure the condition is removed in case drift detection disabled later on
yozel
force-pushed
the
yozel/add-drifted-condition
branch
4 times, most recently
from
5246c26 to
564292c
Compare
This commit introduces a new Kubernetes condition type "Drifted" to improve observability of Helm release drift detection. Signed-off-by: Yasin Özel <yozel@nebius.com>
yozel
force-pushed
the
yozel/add-drifted-condition
branch
from
564292c to
5e52cb3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR Introduces a new condition type "Drifted" to improve observability of Helm release drift detection.
Fix: #1241