runtime/secrets: validate proxy URL scheme and length #1054
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add validation to ProxyURLFromSecret to ensure proxy URLs use supported schemes (http, https, socks5) and do not exceed the maximum length of 2048 characters. This addresses the regression introduced in PR fluxcd#1041 which removed all validation after users reported SOCKS5 proxy breakage. The new implementation properly supports SOCKS5 while maintaining security through scheme and length validation. Signed-off-by: cappyzawa <cappyzawa@gmail.com>
Signed-off-by: cappyzawa <cappyzawa@gmail.com>
cappyzawa
requested review from
a team,
hiddeco and
stefanprodan
as code owners
stefanprodan
approved these changes
Dec 8, 2025
Member
stefanprodan
left a comment
stefanprodan
left a comment
There was a problem hiding this comment.
LGTM
Thanks @cappyzawa 🏅
Member
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: fluxcd/notification-controller#1190 (comment)