Fix sharding flags not being honored

[matheuscscp]

Fixes: #350

Implement sharding (flag already existed).

[matheuscscp]

This PR needs an update here:

https://fluxcd.io/flux/components/source/options/#source-watcher-flags

[Iam-Karan-Suresh]

This PR needs an update here:

https://fluxcd.io/flux/components/source/options/#source-watcher-flags

Hi @matheuscscp I would like to work on that. If it is ok I would like to create a pr

[matheuscscp]

This PR needs an update here:
https://fluxcd.io/flux/components/source/options/#source-watcher-flags

Hi @matheuscscp I would like to work on that. If it is ok I would like to create a pr

Sure, just wait until we merge this one

[stefanprodan]

The flags are there to match SC, removing them will break Flux bootstrapping

[stefanprodan]

Also sharding is not in scope, we are going to break all users of sharding by doing what’s in this PR!

[matheuscscp]

Break?

[matheuscscp]

The flags are there to match SC, removing them will break Flux bootstrapping

Fixed, thanks!

[matheuscscp]

Also sharding is not in scope, we are going to break all users of sharding by doing what’s in this PR!

I think source-watcher is broken now, the binary advertises a flag that does not work, this is quite unexpected:

./source-watcher -h 2>&1 | grep label-selector
      --watch-configs-label-selector string       Watch for ConfigMaps and Secrets with matching labels. (default "reconcile.fluxcd.io/watch=Enabled")
      --watch-label-selector string               Watch for resources with matching labels e.g. 'sharding.fluxcd.io/shard=shard1'.

It's 💯 ok to leave --watch-configs-label-selector there to avoid the bootstrap issue (and if we start looking up ConfigMaps/Secrets later we can just honor the flag), but it's quite absurd to expose --watch-lavel-selector and not honor it, the controller can perfectly do that, and it must if the flag must be kept. This is 100% a bug in my opinion. Whatever breaking change this represents (I don't think it does), we should do it.