Skip to content

feat(framework): Wire SuperExec auth for ClientAppIo#6952

Merged
danieljanes merged 149 commits intomainfrom
appio-authn/pr-5-clientappio-superexec-wiring
Apr 9, 2026
Merged

feat(framework): Wire SuperExec auth for ClientAppIo#6952
danieljanes merged 149 commits intomainfrom
appio-authn/pr-5-clientappio-superexec-wiring

Conversation

@msheller
Copy link
Copy Markdown
Member

@msheller msheller commented Apr 5, 2026

Issue

Description

Part 5/6 of the SuperExec auth stack. This PR is intentionally scoped so reviewers can focus on one or two concepts at a time.

Related issues/PRs

  • Stack root base: appio-authn/2-and-3-wire-serverappio-and-clientappio-auth-interceptors
  • This PR base branch: appio-authn/pr-4-serverappio-superexec-wiring
  • Head branch: appio-authn/pr-5-clientappio-superexec-wiring
  • Previous stack PR branch: appio-authn/pr-4-serverappio-superexec-wiring
  • Companion tests branch: appio-authn/pr-5-clientappio-superexec-wiring-tests

Proposal

Explanation

This PR delivers one reviewable slice of the SuperExec shared-secret auth rollout.

Review focus for this PR:

  • ClientAppIo runtime startup wiring for SuperExec auth
  • SuperNode CLI/runtime plumbing for ClientAppIo path
  • Keep behavior aligned with ServerAppIo wiring conventions

Reviewer notes:

  • This is one PR in a stacked sequence; review against the configured base branch.
  • Companion tests are isolated in a separate branch to keep implementation and verification review clean:
    • appio-authn/pr-5-clientappio-superexec-wiring-tests

Checklist

  • Implement proposed change
  • Write tests (in companion test-only branch)
  • Update documentation
  • Address LLM-reviewer comments, if applicable (e.g., GitHub Copilot)
  • Make CI checks pass
  • Ping maintainers on Slack (channel #contributions)

Any other comments?

This PR is part of a review-focused stacked rollout. If preferred, I can squash/reorder after initial review passes.

msheller and others added 30 commits March 16, 2026 16:30
…or.py

Co-authored-by: Heng Pan <pan@flower.ai>
…or.py

Co-authored-by: Heng Pan <pan@flower.ai>
Base automatically changed from appio-authn/pr-4-serverappio-superexec-wiring to main April 9, 2026 15:14
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6a6f16922a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread framework/py/flwr/supernode/start_client_internal.py
Comment thread framework/py/flwr/supercore/superexec/run_superexec.py Outdated
Comment thread framework/py/flwr/supernode/cli/flower_supernode.py Outdated
Comment thread framework/py/flwr/supernode/start_client_internal.py Outdated
Comment thread framework/py/flwr/supernode/start_client_internal.py Outdated
msheller and others added 2 commits April 9, 2026 09:01
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6500ce9090

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread framework/py/flwr/supercore/superexec/run_superexec.py Outdated
Comment thread framework/py/flwr/supercore/superexec/run_superexec.py Outdated
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 60a1cc59e0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread framework/py/flwr/supercore/superexec/run_superexec.py
Comment thread framework/py/flwr/supernode/start_client_internal.py Outdated
Comment thread framework/py/flwr/supernode/cli/flower_supernode.py
Comment thread framework/py/flwr/supercore/superexec/run_superexec.py Outdated
msheller and others added 3 commits April 9, 2026 09:31
Copy link
Copy Markdown
Member

@panh99 panh99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@danieljanes danieljanes merged commit 800f99b into main Apr 9, 2026
70 checks passed
@danieljanes danieljanes deleted the appio-authn/pr-5-clientappio-superexec-wiring branch April 9, 2026 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Maintainer Used to determine what PRs (mainly) come from Flower maintainers. SuperExec Auth

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants