input: Fix inconsistent axis detection for button-type triggers#2213
Open
inada-s wants to merge 1 commit intoflyinghead:masterfrom
Open
input: Fix inconsistent axis detection for button-type triggers#2213inada-s wants to merge 1 commit intoflyinghead:masterfrom
inada-s wants to merge 1 commit intoflyinghead:masterfrom
Conversation
inada-s
force-pushed
the
fix/analog-input-setting-2
branch
from
7fc3792 to
983423b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When mapping button-type triggers (digital buttons reported as analog axes, like HORI Fighting Commander OCTA), the reverse flag was inconsistently detected. The same mapping operation could result in either reverse=0 or reverse=1 depending on timing. This issue likely affects many arcade sticks.
Video.Project.mp4
Fix
Track last known axis values in lastRawAxisValues and use them to initialize detectingAxes at detection start, ensuring the correct idle state is always set regardless of event timing.