Migrate flyteconnector chart wiring and runtime defaults for Flyte Connectors by kevinliao852 · Pull Request #7377 · flyteorg/flyte

kevinliao852 · 2026-05-15T14:56:43Z

Tracking issue

Why are the changes needed?

This PR completes the first pass of the flyteconnector chart migration to the new Flyte Connectors image/runtime.

What changes were proposed in this pull request?

Wire flyteconnector into flyte-binary as a real Helm dependency
- Vendor the subchart under charts/flyte-binary/charts/
- Update connector image repository from cr.flyte.org/flyteorg/flyteagent to ghcr.io/flyteorg/flyte-connectors
- Change the default connector image tag to latest
- Fix additionalVolumeMounts so extra mounts render under volumeMounts instead of breaking the Deployment YAML
- Remove showcase secret data from default values by making connectorSecret.secretData empty
- Update the connector startup command from the stale
  pyflyte serve agent to the verified runtime command c0

How was this patch tested?

Labels

Please add one or more of the following labels to categorize your PR:

added: For new features.
changed: For changes in existing functionality.
deprecated: For soon-to-be-removed features.
removed: For features being removed.
fixed: For any bug fixed.
security: In case of vulnerabilities

This is important to improve the readability of release notes.

Setup process

Screenshots

Check all the applicable boxes

I updated the documentation accordingly.
All new and existing tests passed.
All commits are signed-off.

Related PRs

Stack

If you do use git town to manage PR Stacks, the stack relevant to this PR
will show below. Otherwise, you can ignore this section.

Docs link

Signed-off-by: Kevin Liao <q85292542000@gmail.com>

- Added `flyteconnector` as a dependency in `Chart.yaml`. - Updated image repository and tag in `flyteconnector` README and `values.yaml` to use the latest version from GitHub. Signed-off-by: Kevin Liao <q85292542000@gmail.com>

…efaults Signed-off-by: Kevin Liao <q85292542000@gmail.com>

Signed-off-by: Kevin Liao <q85292542000@gmail.com>

Copilot

Pull request overview

This PR migrates the flyteconnector Helm chart to the new Flyte Connectors runtime and wires it into flyte-binary as a real Helm subchart dependency. It updates the connector image to ghcr.io/flyteorg/flyte-connectors:latest, switches the container command to flyte serve connector, fixes additionalVolumeMounts rendering, and clears the showcase secret data from the chart defaults.

Changes:

Add flyteconnector as a file://-based subchart dependency of flyte-binary (gated by flyteconnector.enabled).
Update connector image, tag, and startup command in the chart's deployment template and defaults.
Empty out connectorSecret.secretData and adjust template indentation so additional volume mounts render correctly.

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 8 comments.

Show a summary per file

File	Description
charts/flyte-binary/Chart.yaml	Adds the `flyteconnector` subchart as a conditional Helm dependency.
charts/flyteconnector/Chart.yaml	New chart manifest (v0.1.10).
charts/flyteconnector/.helmignore	Standard helm ignore patterns for the new chart.
charts/flyteconnector/README.md	Auto-generated values reference for the new chart.
charts/flyteconnector/values.yaml	New default values: image, ports, RBAC, probes, service, etc.
charts/flyteconnector/templates/_helpers.tpl	Helper templates for names, labels, secret volume/mount, service port.
charts/flyteconnector/templates/connector/deployment.yaml	Connector Deployment with `flyte serve connector` command and fixed volume-mount rendering.
charts/flyteconnector/templates/connector/service.yaml	gRPC ClusterIP Service for the connector.
charts/flyteconnector/templates/connector/serviceaccount.yaml	Optional ServiceAccount with annotations and imagePullSecrets.
charts/flyteconnector/templates/connector/secret.yaml	Opaque Secret pseudo-manifest fed by `connectorSecret.secretData`.
charts/flyteconnector/templates/connector/rbac.yaml	Optional ClusterRole/ClusterRoleBinding for cross-namespace secret reads.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

pingsutw · 2026-05-29T06:14:56Z

+{{- end }}
+
+{{- define "flyteconnector.servicePort" -}}
+{{ include .Values.ports.containerPort}}


copilot might be right

Done. I've made the requested changes

+# -- Default regex string for searching configuration files
+configPath: /etc/flyteconnector/config/*.yaml


+# commonLabels Add labels to all the deployed resources
+commonLabels: {}
+# commonAnnotations Add annotations to all the deployed resources
+commonAnnotations: {}


+  # -- Docker image for flyteconnector deployment
+  repository: ghcr.io/flyteorg/flyte-connectors  # FLYTECONNECTOR_IMAGE
+  # -- Docker image tag
+  tag: latest  # FLYTECONNECTOR_TAG


pingsutw · 2026-05-29T06:13:34Z

+apiVersion: v1
+kind: Secret
+metadata:
+  name: {{ template "flyteconnector.name" . }}
+  namespace: {{ template "flyte.namespace" . }}
+type: Opaque
+{{- with .Values.connectorSecret.secretData -}}


should we update here?

Yes, I updated this by making the Secret conditional on connectorSecret.secretData.
When secretData is empty, the chart no longer renders an empty Opaque Secret.

+  {{- end}}
+{{- with .Values.serviceAccount.imagePullSecrets }}
+imagePullSecrets: {{ tpl (toYaml .) $ | nindent 2 }}
+{{- end }}
+{{- end }}


Signed-off-by: Kevin Liao <q85292542000@gmail.com>

…connector

pingsutw · 2026-05-29T06:13:34Z

+apiVersion: v1
+kind: Secret
+metadata:
+  name: {{ template "flyteconnector.name" . }}
+  namespace: {{ template "flyte.namespace" . }}
+type: Opaque
+{{- with .Values.connectorSecret.secretData -}}


should we update here?

pingsutw · 2026-05-29T06:14:56Z

+{{- end }}
+
+{{- define "flyteconnector.servicePort" -}}
+{{ include .Values.ports.containerPort}}


copilot might be right

pingsutw · 2026-05-29T06:15:35Z

+name: flyteconnector
+description: A Helm chart for Flyte connector
+type: application
+version: v0.1.10  # VERSION


Suggested change

version: v0.1.10 # VERSION

version: v2.0.0 # VERSION

Thanks. I've switched to v2.0.0

pingsutw · 2026-05-29T06:19:59Z

+  # -- Docker image for flyteconnector deployment
+  repository: ghcr.io/flyteorg/flyte-connectors  # FLYTECONNECTOR_IMAGE
+  # -- Docker image tag
+  tag: latest  # FLYTECONNECTOR_TAG


use 2.3.6 for now. ghcr.io/flyteorg/flyte-connectors:py3.12-v2.3.6

Thanks for the clarification. I'll use ghcr.io/flyteorg/flyte-connectors:py3.12-v2.3.6 for now.

pingsutw · 2026-05-29T06:22:23Z

+
+dependencies:
+  - name: flyteconnector
+    version: v0.1.10


Suggested change

version: v0.1.10

version: v2.0.0

…connector

Signed-off-by: Kevin Liao <q85292542000@gmail.com>

Copilot

Pull request overview

Copilot reviewed 12 out of 12 changed files in this pull request and generated 8 comments.

+{{- define "flyteconnector.name" -}}
+{{- default .Chart.Name .Values.nameOverride | trunc 63 | trimSuffix "-" -}}
+{{- end -}}


+        {{- if or .Values.connectorSecret.secretData .Values.additionalVolumeMounts }}
+        volumeMounts:
+        {{- include "connectorSecret.volumeMount" . | nindent 8 }}
+        {{- with .Values.additionalVolumeMounts -}}
+        {{ tpl (toYaml .) $ | nindent 8 }}
+        {{- end }}
+        {{- end }}


+      serviceAccountName: {{ template "flyteconnector.name" . }}
+      {{- if or .Values.connectorSecret.secretData .Values.additionalVolumes }}
+      volumes: {{- include "connectorSecret.volume" . | nindent 6 }}
+      {{- with .Values.additionalVolumes -}}
+      {{ tpl (toYaml .) $ | nindent 6 }}
+      {{- end }}
+      {{- end }}


+      annotations:
+        {{- with .Values.podAnnotations }}
+        {{- toYaml . | nindent 8 }}
+        {{- end }}


+        readinessProbe:
+        {{- with .Values.readinessProbe -}}
+          {{ tpl (toYaml .) $ | nindent 10 }}
+        {{- end }}


+{{- define "flyte.name" -}}
+{{- default .Chart.Name .Values.nameOverride | trunc 63 | trimSuffix "-" -}}
+{{- end -}}
+
+{{- define "flyte.chart" -}}
+{{- printf "%s-%s" .Chart.Name .Chart.Version | replace "+" "_" | trunc 63 | trimSuffix "-" -}}
+{{- end -}}
+
+{{- define "flyte.namespace" -}}
+{{- default .Release.Namespace .Values.forceNamespace | trunc 63 | trimSuffix "-" -}}
+{{- end -}}


+name: flyteconnector
+description: A Helm chart for Flyte connector
+type: application
+version: v2.0.0  # VERSION


+  ports:
+  - name: {{ .Values.ports.name }}
+    port: {{ .Values.ports.containerPort }}
+    protocol: TCP
+    appProtocol: TCP


Signed-off-by: Kevin Liao <q85292542000@gmail.com>

Copilot

Pull request overview

Copilot reviewed 12 out of 12 changed files in this pull request and generated 9 comments.

+      - command:
+        - c0
+        {{- if .Values.podEnv }}
+        env:
+        {{- with .Values.podEnv }}
+        {{- toYaml . | nindent 8 }}
+        {{- end }}
+        {{- end }}


+    port: {{ .Values.ports.containerPort }}
+    protocol: TCP
+    appProtocol: TCP
+    targetPort: {{ .Values.ports.name }}


+  # -- Docker image tag
+  tag: py3.12-v2.3.6  # FLYTECONNECTOR_TAG


+# -- Default regex string for searching configuration files
+configPath: /etc/flyteconnector/config/*.yaml


+# -- Appends additional containers to the deployment spec. May include template values.
+additionalContainers: []
+# -- Appends extra command line arguments to the main command
+extraArgs: {}


+  name: {{ template "flyteconnector.name" . }}
+  namespace: {{ template "flyte.namespace" . }}
+  labels: {{ include "flyteconnector.labels" . | nindent 4 }}


+podAnnotations: {}
+# -- Additional flyteconnector pod container environment variables
+podEnv: {}
+# -- Labels for flyteconnector pods
+podLabels: {}


+dependencies:
+  - name: flyteconnector
+    version: v2.0.0
+    repository: file://../flyteconnector
+    condition: flyteconnector.enabled


+# nameOverride String to override flyteconnector.name template
+nameOverride: ""
+# fullnameOverride String to override flyteconnector.fullname template
+fullnameOverride: ""


kevinliao852 added 4 commits May 15, 2026 06:46

migrate raw files

70f32c3

Signed-off-by: Kevin Liao <q85292542000@gmail.com>

Update Flyte binary chart

c36d214

- Added `flyteconnector` as a dependency in `Chart.yaml`. - Updated image repository and tag in `flyteconnector` README and `values.yaml` to use the latest version from GitHub. Signed-off-by: Kevin Liao <q85292542000@gmail.com>

fix(helm): wire flyteconnector subchart and correct connector image d…

881ffdb

…efaults Signed-off-by: Kevin Liao <q85292542000@gmail.com>

Update Flyte connector configuration and deployment

0fc3d0c

Signed-off-by: Kevin Liao <q85292542000@gmail.com>

Copilot AI review requested due to automatic review settings May 15, 2026 14:56

github-actions Bot added the flyte2 label May 15, 2026

Copilot started reviewing on behalf of kevinliao852 May 15, 2026 14:57 View session

Copilot AI reviewed May 15, 2026

View reviewed changes

kevinliao852 added 2 commits May 22, 2026 17:31

fix(flyteconnector): render connector secret only when configured

c0dffa7

Signed-off-by: Kevin Liao <q85292542000@gmail.com>

Merge remote-tracking branch 'origin/main' into feature/migrate-flyte…

a5c944d

…connector

pingsutw reviewed May 29, 2026

View reviewed changes

kevinliao852 added 2 commits May 30, 2026 06:39

Merge remote-tracking branch 'origin/main' into feature/migrate-flyte…

3709892

…connector

fix(helm): set flyteconnector chart version to v2.0.0

e4544d4

Signed-off-by: Kevin Liao <q85292542000@gmail.com>

Copilot AI review requested due to automatic review settings May 29, 2026 22:50

Copilot AI reviewed May 29, 2026

View reviewed changes

fix(helm): use c0 entrypoint and pin flyteconnector to py3.12-v2.3.6

1ab9da3

Signed-off-by: Kevin Liao <q85292542000@gmail.com>

pingsutw approved these changes Jun 6, 2026

View reviewed changes

pingsutw marked this pull request as ready for review June 6, 2026 00:10

Copilot AI review requested due to automatic review settings June 6, 2026 00:10

Copilot started reviewing on behalf of pingsutw June 6, 2026 00:11 View session

Copilot AI reviewed Jun 6, 2026

View reviewed changes

		# -- Default regex string for searching configuration files
		configPath: /etc/flyteconnector/config/*.yaml

		# -- Docker image tag
		tag: py3.12-v2.3.6 # FLYTECONNECTOR_TAG

Conversation

kevinliao852 commented May 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Tracking issue

Why are the changes needed?

What changes were proposed in this pull request?

How was this patch tested?

Labels

Setup process

Screenshots

Check all the applicable boxes

Related PRs

Stack

Docs link

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

kevinliao852 commented May 15, 2026 •

edited

Loading