Rename cluster to queue#7397
Open
iaroslav-ciupin wants to merge 5 commits into
Open
Conversation
iaroslav-ciupin
force-pushed
the
yaroslav/queue-idl
branch
from
0fab7a7 to
65c91f8
Compare
Signed-off-by: Iaroslav Ciupin <iaroslav@union.ai>
Signed-off-by: Iaroslav Ciupin <iaroslav@union.ai>
iaroslav-ciupin
force-pushed
the
yaroslav/queue-idl
branch
from
65c91f8 to
5408467
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR renames the cluster field to queue in the Flyte v2 protobuf API surface for run/task execution targeting, and updates the generated client/server bindings accordingly.
Changes:
- Rename
TaskAction.cluster→TaskAction.queue(flyteidl2/workflow/run_definition.proto+ generated code). - Rename
RunSpec.cluster→RunSpec.queue(flyteidl2/task/run.proto+ generated code). - Regenerate Go/TypeScript/Python artifacts (and buf validation stubs) to reflect the renamed fields.
Reviewed changes
Copilot reviewed 6 out of 14 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| gen/ts/flyteidl2/workflow/run_definition_pb.ts | Updates TS generated types/docs for TaskAction.queue. |
| gen/ts/flyteidl2/task/run_pb.ts | Updates TS generated types/docs for RunSpec.queue. |
| gen/python/flyteidl2/workflow/run_definition_pb2.pyi | Updates Python typing stubs for TaskAction.queue. |
| gen/python/flyteidl2/workflow/run_definition_pb2.py | Updates Python generated descriptors for TaskAction.queue. |
| gen/python/flyteidl2/task/run_pb2.pyi | Updates Python typing stubs for RunSpec.queue. |
| gen/python/flyteidl2/task/run_pb2.py | Updates Python generated descriptors for RunSpec.queue. |
| gen/go/flyteidl2/workflow/run_definition.pb.validate.go | Updates validation stub comments for renamed field. |
| gen/go/flyteidl2/task/run.pb.validate.go | Updates validation stub comments for renamed field. |
| gen/go/flyteidl2/task/run.pb.go | Updates Go generated struct/getter for RunSpec.queue. |
| flyteidl2/workflow/run_definition.proto | Renames protobuf field cluster → queue on TaskAction. |
| flyteidl2/task/run.proto | Renames protobuf field cluster → queue on RunSpec. |
Files not reviewed (6)
- gen/go/flyteidl2/task/run.pb.go: Generated file
- gen/go/flyteidl2/task/run.pb.validate.go: Generated file
- gen/go/flyteidl2/workflow/run_definition.pb.go: Generated file
- gen/go/flyteidl2/workflow/run_definition.pb.validate.go: Generated file
- gen/python/flyteidl2/task/run_pb2.py: Generated file
- gen/python/flyteidl2/workflow/run_definition_pb2.py: Generated file
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+54
to
+56
| // the specific queue that this action should be executed on. | ||
| // this value will be used to resolve the full queue id and store it in 'assigned_queue' field. | ||
| string queue = 4; |
Signed-off-by: Iaroslav Ciupin <iaroslav@union.ai>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 14 changed files in this pull request and generated 2 comments.
Files not reviewed (6)
- gen/go/flyteidl2/task/run.pb.go: Generated file
- gen/go/flyteidl2/task/run.pb.validate.go: Generated file
- gen/go/flyteidl2/workflow/run_definition.pb.go: Generated file
- gen/go/flyteidl2/workflow/run_definition.pb.validate.go: Generated file
- gen/python/flyteidl2/task/run_pb2.py: Generated file
- gen/python/flyteidl2/workflow/run_definition_pb2.py: Generated file
Signed-off-by: Iaroslav Ciupin <iaroslav@union.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking issue
Why are the changes needed?
What changes were proposed in this pull request?
How was this patch tested?
Labels
Please add one or more of the following labels to categorize your PR:
This is important to improve the readability of release notes.
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Stack
If you do use
git townto manage PR Stacks, the stack relevant to this PRwill show below. Otherwise, you can ignore this section.
Docs link