fix(flytestdlib): initialize metrics scope and expose /metrics endpoi…#7473
Open
vic-comm wants to merge 1 commit into
Open
fix(flytestdlib): initialize metrics scope and expose /metrics endpoi…#7473vic-comm wants to merge 1 commit into
vic-comm wants to merge 1 commit into
Conversation
vic-comm
force-pushed
the
fix/v2-app-metrics-endpoint
branch
from
f714356 to
06e2906
Compare
…nt in v2 app framework Signed-off-by: Victor Chidera Obiezue <obiezuechidera@gmail.com>
vic-comm
force-pushed
the
fix/v2-app-metrics-endpoint
branch
from
06e2906 to
a4df17d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves the missing /metrics endpoint in the v2 app framework.
Initializes sc.Scope = promutils.NewScope(a.Name) prior to calling a.Setup(...) to prevent nil pointer exceptions in standalone binaries. (Respects existing scopes if already initialized by the unified manager).
Mounts promhttp.Handler() at /metrics alongside the existing health checks.
Includes a unit test asserting scope initialization and a 200 OK from the metrics endpoint.
Fixes: #7446