fix(flyteadmin): populate ErrorKind/ErrorCode columns for accept-time execution failures#7496
Open
1fanwang wants to merge 1 commit into
Open
Conversation
… execution failures Signed-off-by: 1fanwang <1fannnw@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7496 +/- ##
=======================================
Coverage 57.03% 57.04%
=======================================
Files 931 931
Lines 58387 58395 +8
=======================================
+ Hits 33301 33311 +10
+ Misses 22025 22023 -2
Partials 3061 3061
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
FlyteAdmin records an execution's error kind and code in dedicated, indexed columns so operators can query and alert on failures without unpacking each execution's serialized closure. These columns are filled in for failures reported through the propeller event stream, but not for executions that fail at creation time (for example, validation failures rejected before the workflow ever starts). Those executions are stored as
FAILEDwith the error only inside the closure blob, so any query or alert that filters on the error-kind column silently misses them.What changes were proposed in this pull request?
Populate the error-kind and error-code columns when an execution is created in a failed state, matching what already happens for event-driven failures. Successful executions leave the columns empty as before.
How was this patch tested?
Extended
TestCreateExecutionModel: the success case asserts both columns are empty; the unknown / invalid-argument / internal error cases assert the columns match the failure's kind and code.Reproduce:
Before:
After:
Labels
fixed
Check all the applicable boxes