Skip to content

86b7hgwp7 - Fix: replace message when deleting item #736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
niko-exo wants to merge 3 commits into
base: master
Choose a base branch
from
Open

86b7hgwp7 - Fix: replace message when deleting item #736

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
53eca26
fix: allow custom body to be set on deletion modal
niko-exo Dec 22, 2025
2ddd97e
fix: use custom body text on deletion modal
niko-exo Dec 22, 2025
21c2dcf
fix: add i18n entry
niko-exo Dec 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/components/mui/editable-table/mui-table-editable.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,8 @@ const MuiTableEditable = ({
onEdit,
onArchive,
onDelete,
onCellChange // New prop for handling cell value changes
onCellChange, // New prop for handling cell value changes
deleteDialogBody
}) => {
// State to track which cell is currently being edited
const [editingCell, setEditingCell] = React.useState(null);
Expand Down Expand Up @@ -165,7 +166,9 @@ const MuiTableEditable = ({
const handleDelete = async (item) => {
const isConfirmed = await showConfirmDialog({
title: T.translate("general.are_you_sure"),
text: `${T.translate("general.row_remove_warning")} ${getName(item)}`,
text: deleteDialogBody
? deleteDialogBody(getName(item))
: `${T.translate("general.row_remove_warning")} ${getName(item)}`,
type: "warning",
showCancelButton: true,
confirmButtonColor: "#DD6B55",
Expand Down
1 change: 1 addition & 0 deletions src/i18n/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2543,6 +2543,7 @@
"item_delete_success": "Item successfully deleted.",
"add_inventory_item": "Add Inventory Item",
"add_form_template_item": "Create new Item",
"delete_dialog_body": "Please verify you want to delete {name}",
"placeholders": {
"search_form_template_items": "Search"
},
Expand Down
3 changes: 3 additions & 0 deletions src/pages/sponsors/sponsor-form-item-list-page/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,6 +303,9 @@ const SponsorFormItemListPage = ({
onCellChange={handleCellEdit}
onEdit={handleRowEdit}
onArchive={handleArchiveItem}
deleteDialogBody={(name) => T.translate("sponsor_form_item_list.delete_dialog_body", {
name
})}
/>
</div>
)}
Expand Down