Add crude type parsing for jai tokenizer#106
Open
rainbowism wants to merge 2 commits intofocus-editor:mainfrom
Open
Add crude type parsing for jai tokenizer#106rainbowism wants to merge 2 commits intofocus-editor:mainfrom
rainbowism wants to merge 2 commits intofocus-editor:mainfrom
Conversation
Owner
|
Thanks for the PR! I tried to do it myself but decided against it because there are too many special cases (see screenshots) I'm honestly not sure it's even worth it to try to highlight user types using tokens at this point. The plan was to leverage the compiler eventually to get a list of types asynchronously and put it in a hash map for highlighting (and other things) |
Author
|
That's fair. I have actually resolved those 2 scenarios but if the plan is for using the compiler rather than a bespoke tokenizer then that seems like a better plan. |
Owner
Author
|
That's fine with me. I can just use this personally for now in the meanwhile, or somebody can pull in my branch if they wish to use it themselves. |
Owner
|
Great. Thank you for your understanding! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.





It'll highlights the types in most situations. It isn't a very robust solution but after some testing it seems to work well enough.