Switch from genisoimage to xorriso#182
Merged
Merged
Conversation
evgeni
reviewed
Feb 25, 2026
| def generate_config_iso_in_dir(dir_path, user_data, &blk) | ||
| FileUtils.touch(File.join(dir_path, "meta-data")) | ||
| File.open(File.join(dir_path, 'user-data'), 'w') { |f| f.write user_data } | ||
| meta_data_path = File.join(dir_path, "meta-data") |
Contributor
There was a problem hiding this comment.
Suggested change
| meta_data_path = File.join(dir_path, "meta-data") | |
| meta_data_path = File.join(dir_path, 'meta-data') |
evgeni
approved these changes
Feb 25, 2026
This makes it easier to follow what's related
The genisoimage package is no longer available in EL10 because it was long unmaintained. The xorrisofs command is a drop in replacement.
This avoids using a shell and can deal properly with spaces in paths.
ekohl
force-pushed
the
replace-genisoimage
branch
from
3c53a16 to
f6e01e5
Compare
evgeni
approved these changes
Mar 16, 2026
Contributor
evgeni
left a comment
evgeni
left a comment
There was a problem hiding this comment.
Tested with rubygem-fog-libvirt-0.14.0-1.20260225102147357229.pr182.6.gf6e01e5.el9.noarch on an EL9 machine where I manually deleted /usr/bin/genisoimage and there was a valid cloud-init ISO attached to my VM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The genisoimage package is no longer available in EL10 because it was long unmaintained. The xorrisofs command is a drop in replacement.
Also does some further clean ups.
Fixes #181