-
Notifications
You must be signed in to change notification settings - Fork 28
CIRC-2292: Implement Request Anonymization API #1631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
could you make correct those errors, please. ERROR: api-schema-lint: ramls/schema/anonymization-result.json: Missing top-level "description". |
|
please make sure the test coverage for your new code is greater than 80% |
yuntianhu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you mirror loan anon. raml file, please.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you add top level description, please. thank you
| import org.folio.circulation.domain.RequestStatus; | ||
| import org.folio.circulation.support.logging.Logging; | ||
|
|
||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove extra space, please
|
|
||
| // Get includeCirculationLogs parameter (default to true) | ||
| boolean includeCirculationLogs = body.getBoolean("includeCirculationLogs", true); | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove extra space here, please
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the end point should be /request-anonymization/ instead of circulation/request-anonymization/
yuntianhu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please study this ticket
https://folio-org.atlassian.net/browse/UXPROD-4302?quickFilter=2727&selectedIssue=CIRC-2292
|


CIRC-2292: Implement Request Anonymization API
Summary
Adds a POST endpoint to anonymize closed circulation requests in bulk, removing personally identifiable information from request records.
Changes
New Endpoint: POST /circulation/requests/anonymize
Validation: Verifies requests have closed status before anonymization
Delegate to Storage: Calls mod-circulation-storage for actual anonymization
Tests: Unit and integration tests for the new functionality
Schema: Added request/response JSON schemas and RAML definitions