Skip to content

Conversation

@akx
Copy link

@akx akx commented Jan 27, 2025

What kind of change does this PR introduce?

  • Bugfix of sorts.

Even if Prettier had technically been configured for the repo, it was never enforced, so various contributions had caused the repo to drift from Prettier style.

This PR:

  • adds prettier --check to the GitHub Actions CI workflow
  • adjusts the prettier settings so files in sub-subdirectories are properly formatted too, while ignoring (for the time being anyway) some files that would have made the diff here >10k lines.
  • reformats files using prettier --write.

If this PR is merged, the resulting commit hash should probably be added to .git-blame-ignore-revs.

Refs #1587, 6603d6a.

Checklist:

  • Unit Tests
    • Yes, in that CI now actually enforces Prettier style
  • Documentation (N/A)
  • Update CHANGELOG.md (N/A)
  • Ready to be merged

@akx akx marked this pull request as draft January 27, 2025 09:20
@akx akx force-pushed the apply-prettier branch 2 times, most recently from c934648 to 1fe0f7e Compare January 27, 2025 09:25
@akx akx marked this pull request as ready for review January 27, 2025 09:27
@blikblum
Copy link
Member

Please remove the examples folder. Prettier makes harder to understand some code there

@akx akx force-pushed the apply-prettier branch 2 times, most recently from c3d075e to 6f371a8 Compare January 28, 2025 09:54
@akx
Copy link
Author

akx commented Jan 28, 2025

Please remove the examples folder. Prettier makes harder to understand some code there

Yeah, I see what you mean with the chained calls. I added a commit that peppers // prettier-ignore comments around them (as had been done with other code elsewhere).

@akx
Copy link
Author

akx commented Feb 7, 2025

@blikblum Rebased.

@blikblum
Copy link
Member

Many thanks. I've applied the patch manually due to conflicts

@blikblum blikblum closed this Apr 12, 2025
@akx
Copy link
Author

akx commented Apr 13, 2025

No worries (though too bad my authorship information was gone 😕). I could've rebased it too :)

@blikblum
Copy link
Member

Sorry. I did in two steps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants