Skip to content

Fix warnings #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
greetingsfellowhumans wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix warnings #33

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
09c02e9
Fix negative range steps
greetingsfellowhumans Jul 3, 2026
fdbc8b6
Remove redundant type-checking tests
greetingsfellowhumans Jul 3, 2026
a78e76f
Replace Mix.Config with Config
greetingsfellowhumans Jul 3, 2026
4acfbb4
Remove empty config
greetingsfellowhumans Jul 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 0 additions & 30 deletions config/config.exs
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion lib/math.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -583,7 +583,7 @@ defmodule Math do
new_points =
control_points
|> Enum.with_index()
|> Enum.slice(0..-2)
|> Enum.slice(0..-2//1)

@chatgpt-codex-connector chatgpt-codex-connector Bot Jul 3, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Keep slice syntax compatible with supported Elixir

This package still declares elixir: "~> 1.4" in mix.exs, and .travis.yml explicitly tests Elixir 1.4.5 through 1.9.4, but the new stepped-range syntax (..//) was added in later Elixir releases. As a result, users and CI jobs on the declared supported versions cannot even parse this file, so fixing the warning for newer Elixir versions currently breaks older supported environments.

Useful? React with 👍 / 👎.

|> Enum.map(
fn {p0, index} ->
next_index = index + 1
Expand Down
8 changes: 0 additions & 8 deletions test/math_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,14 +175,6 @@ defmodule MathTest do
assert_raise ArithmeticError, fn -> isqrt(-2) end
end

test "mod_inv" do
assert_raise ArgumentError, fn -> mod_inv(1.0, 3.5) end
end

test "mod_inv!" do
assert_raise ArgumentError, fn -> mod_inv!(1.0, 3.5) end
end

test "interpolation" do
p0 = {0, 0}
p1 = {1, 1}
Expand Down