New feature flag for welcome discovery (WD)#2834
Conversation
| @@ -901,6 +902,20 @@ open class LoginActivity : FragmentActivity() { | |||
| */ | |||
| private fun applySalesforceWelcomeDiscoveryIntent(intent: Intent) { | |||
There was a problem hiding this comment.
@JohnsonEricAtSalesforce Does this look like the right place?
From my debugging, this method always gets called: for regular logins, and also for 1st or 2nd part of login with welcome discovery.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #2834 +/- ##
============================================
+ Coverage 63.24% 63.30% +0.05%
- Complexity 2825 2836 +11
============================================
Files 216 216
Lines 16982 16996 +14
Branches 2418 2420 +2
============================================
+ Hits 10741 10760 +19
+ Misses 5072 5068 -4
+ Partials 1169 1168 -1
🚀 New features to boost your workflow:
|
| // Re-apply user agent to WebView | ||
| webView.settings.userAgentString = SalesforceSDKManager.getInstance().userAgent |
There was a problem hiding this comment.
Not for this PR, just thinking out loud: It would be awesome to use LiveData to make this happen automatically so we don't accidentally forget to update the WebView. Just like how the login url the WebView uses gets automatically generated when the selected server changes, registering/unregistering a feature flag (and potentially other things) should regenerate and set the value in the WebView.
|
@wmathurin Looks like the |
…re flag in user agent
Fixed by 68cfc80 |
| assertTrue(activity.switchDefaultOrSalesforceWelcomeDiscoveryLogin(PRODUCTION_LOGIN_URL.toUri())) | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
New tests checking the feature flag on the user agent for various scenario:
- welcome discovery login server
- my domain login server hint (that happens in part 2 of wsc disco flow)
- my domain login server (should not have the WD feature flag)
|
All 574 unit tests are passing - see https://github.com/forcedotcom/SalesforceMobileSDK-Android/pull/2834/checks?check_run_id=62694114940 |
2 participants
No description provided.