Release 1.0.8

.github/workflows/flutter.yaml

@@ -8,10 +8,36 @@ jobs:
     name: Validate
     runs-on: macos-latest
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
       - uses: subosito/flutter-action@v2
         with:
           channel: stable
       - name: Run Flutter validation script
         run: ./validate.sh
         shell: bash
+
+  integration-android:
+    name: Android integration tests
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - uses: actions/setup-java@v4
+        with:
+          distribution: temurin
+          java-version: '17'
+      - uses: subosito/flutter-action@v2
+        with:
+          channel: stable
+      - name: Enable KVM
+        run: |
+          echo 'KERNEL=="kvm", GROUP="kvm", MODE="0666", OPTIONS+="static_node=kvm"' \
+            | sudo tee /etc/udev/rules.d/99-kvm4all.rules
+          sudo udevadm control --reload-rules
+          sudo udevadm trigger --name-match=kvm
+      - name: Run integration tests on Android emulator
+        uses: reactivecircus/android-emulator-runner@v2
+        with:
+          api-level: 34
+          arch: x86_64
+          profile: pixel_6
+          script: cd example && flutter pub get && flutter test integration_test

.gitignore

@@ -25,6 +25,7 @@
 **/doc/api/
 .dart_tool/
 .flutter-plugins
+.flutter-plugins-dependencies
 .packages
 .pub-cache/
 .pub/
@@ -37,3 +38,7 @@ lib/generated_plugin_registrant.dart
 !/packages/flutter_tools/test/data/dart_dependencies_test/**/.packages
 example/android/app/.cxx/Debug
 example/ios/Flutter/ephemeral
+
+# Local symlink to the sibling flutter_markdown_plus_latex package, used for
+# cross-package development. Not part of this repository.
+flutter_markdown_plus_latex

.pubignore

@@ -1,3 +1,6 @@
+# Local symlink to the sibling flutter_markdown_plus_latex package (dev only)
+flutter_markdown_plus_latex/
+
 # Example build artifacts
 example/build/
 example/.dart_tool/

CHANGELOG.md

@@ -1,3 +1,25 @@
+## 1.0.8
+
+* Fixed custom `builders` and `paddingBuilders` for the `hr` tag being ignored
+* Fixed bold, italic, and link formatting not rendering inside blockquotes
+* Forced a consistent line height within each text block so mixed font weights (e.g. bold) no longer shift line height, while headers and other blocks keep their own height
+* Updated the default blockquote styling to be theme-aware (uses `surfaceContainerHighest` with a primary-coloured left border) for better light/dark mode support
+* Added a `noScroll` option to the `Markdown` widget to render content in a non-scrolling `Column` for use inside an existing scroll view
+* Added an integration test suite (`example/integration_test/`) that runs on a device or emulator, covering link taps, scrolling, task-list checkboxes, text selection, and example app launch
+* Added `scripts/integration_test.sh` and a GitHub Actions job that runs the integration tests on an Android emulator
+* Migrated linting to `package:flutter_lints`, retaining strict type analysis and required public API documentation
+* Updated dependencies: `markdown` to `^7.3.1`, `mockito` to `^5.7.0`, and pinned `leak_tracker_flutter_testing`
+* Aligned the example app's Flutter constraint with the package and added a `documentation` link to the pubspec
+* Updated the example app's Android Gradle Plugin to 8.6.0 (Flutter's current minimum) and removed an unused Google Cloud Artifact Registry Gradle plugin
+* Excluded the locally symlinked `flutter_markdown_plus_latex` package from analysis and publishing
+
+**Thanks to our contributors:**
+* [@joelbrostrom](https://github.com/joelbrostrom) for fixing custom builders on the `hr` tag (#131)
+* [@vsaase](https://github.com/vsaase) for fixing inline formatting inside blockquotes (#128)
+* [@domhel](https://github.com/domhel) for theme-aware blockquote styling (#42)
+* [@szuwest](https://github.com/szuwest) for the strong text line-height fix (#130)
+* [@senlinjun](https://github.com/senlinjun) for the `noScroll` option (#38)
+
 ## 1.0.7
 
 * Improved pub.dev score by making example app source code available in published package

analysis_options.yaml

@@ -1,245 +1,39 @@
-# Specify analysis options.
+# Analysis options for flutter_markdown_plus.
 #
-# This file is a copy of analysis_options.yaml from flutter repo
-# as of 2023-12-18, but with some modifications marked with
-# "DIFFERENT FROM FLUTTER/FLUTTER" below. The file is expected to
-# be kept in sync with the master file from the flutter repo.
+# Builds on the standard package:flutter_lints rule set (the convention for
+# published Flutter packages), layered with a few stricter settings this package
+# relies on: type-strict analysis and required public API documentation.
+
+include: package:flutter_lints/flutter.yaml
 
 analyzer:
   language:
     strict-casts: true
     strict-inference: true
     strict-raw-types: true
   errors:
-    # allow deprecated members (we do this because otherwise we have to annotate
-    # every member in every test, assert, etc, when we or the Dart SDK deprecates
-    # something (https://github.com/flutter/flutter/issues/143312)
+    # Allow deprecated members: otherwise every usage would need annotating each
+    # time the Dart SDK or Flutter deprecates something we still support.
+    # https://github.com/flutter/flutter/issues/143312
     deprecated_member_use: ignore
     deprecated_member_use_from_same_package: ignore
-  exclude: # DIFFERENT FROM FLUTTER/FLUTTER
-    # Ignore generated files
+  exclude:
+    # Generated files.
     - '**/*.g.dart'
     - '**/*.mocks.dart' # Mockito @GenerateMocks
-
+    # Locally symlinked sibling package (flutter_markdown_plus_latex) used for
+    # cross-package development; not part of this package.
+    - 'flutter_markdown_plus_latex/**'
+
 formatter:
   page_width: 120
 
 linter:
   rules:
-    # This list is derived from the list of all available lints located at
-    # https://github.com/dart-lang/linter/blob/main/example/all.yaml
-    - always_declare_return_types
-    - always_put_control_body_on_new_line
-    # - always_put_required_named_parameters_first # we prefer having parameters in the same order as fields https://github.com/flutter/flutter/issues/10219
-    - always_specify_types
-    # - always_use_package_imports # we do this commonly
-    - annotate_overrides
-    # - avoid_annotating_with_dynamic # conflicts with always_specify_types
-    - avoid_bool_literals_in_conditional_expressions
-    # - avoid_catches_without_on_clauses # blocked on https://github.com/dart-lang/linter/issues/3023
-    # - avoid_catching_errors # blocked on https://github.com/dart-lang/linter/issues/3023
-    # - avoid_classes_with_only_static_members # we do this commonly for `abstract final class`es
-    - avoid_double_and_int_checks
-    - avoid_dynamic_calls
-    - avoid_empty_else
-    - avoid_equals_and_hash_code_on_mutable_classes
-    - avoid_escaping_inner_quotes
-    - avoid_field_initializers_in_const_classes
-    # - avoid_final_parameters # incompatible with prefer_final_parameters
-    - avoid_function_literals_in_foreach_calls
-    # - avoid_implementing_value_types # see https://github.com/dart-lang/linter/issues/4558
-    - avoid_init_to_null
-    - avoid_js_rounded_ints
-    # - avoid_multiple_declarations_per_line # seems to be a stylistic choice we don't subscribe to
-    # - avoid_positional_boolean_parameters # would have been nice to enable this but by now there's too many places that break it
-    - avoid_print
-    # - avoid_private_typedef_functions # we prefer having typedef (discussion in https://github.com/flutter/flutter/pull/16356)
-    - avoid_redundant_argument_values
-    - avoid_relative_lib_imports
-    - avoid_renaming_method_parameters
-    - avoid_return_types_on_setters
-    - avoid_returning_null_for_void
-    # - avoid_returning_this # there are enough valid reasons to return `this` that this lint ends up with too many false positives
-    - avoid_setters_without_getters
-    - avoid_shadowing_type_parameters
-    - avoid_single_cascade_in_expression_statements
-    - avoid_slow_async_io
-    - avoid_type_to_string
-    - avoid_types_as_parameter_names
-    # - avoid_types_on_closure_parameters # conflicts with always_specify_types
-    - avoid_unnecessary_containers
-    - avoid_unused_constructor_parameters
-    - avoid_void_async
-    # - avoid_web_libraries_in_flutter # we use web libraries in web-specific code, and our tests prevent us from using them elsewhere
-    - await_only_futures
-    - camel_case_extensions
-    - camel_case_types
-    - cancel_subscriptions
-    # - cascade_invocations # doesn't match the typical style of this repo
-    - cast_nullable_to_non_nullable
-    # - close_sinks # not reliable enough
-    - collection_methods_unrelated_type
-    - combinators_ordering
-    # - comment_references # blocked on https://github.com/dart-lang/linter/issues/1142
-    - conditional_uri_does_not_exist
-    # - constant_identifier_names # needs an opt-out https://github.com/dart-lang/linter/issues/204
-    - control_flow_in_finally
-    - curly_braces_in_flow_control_structures
-    - dangling_library_doc_comments
-    - depend_on_referenced_packages
-    - deprecated_consistency
-    # - deprecated_member_use_from_same_package # we allow self-references to deprecated members
-    # - diagnostic_describe_all_properties # enabled only at the framework level (packages/flutter/lib)
-    - directives_ordering
-    # - discarded_futures # too many false positives, similar to unawaited_futures
-    # - do_not_use_environment # there are appropriate times to use the environment, especially in our tests and build logic
-    - empty_catches
-    - empty_constructor_bodies
-    - empty_statements
-    - eol_at_end_of_file
-    - exhaustive_cases
-    - file_names
-    - flutter_style_todos
-    - hash_and_equals
-    - implementation_imports
-    - implicit_call_tearoffs
-    - implicit_reopen
-    - invalid_case_patterns
-    # - join_return_with_assignment # not required by flutter style
-    - leading_newlines_in_multiline_strings
-    - library_annotations
-    - library_names
-    - library_prefixes
-    - library_private_types_in_public_api
-    # - lines_longer_than_80_chars # not required by flutter style
-    - literal_only_boolean_expressions
-    # - matching_super_parameters # blocked on https://github.com/dart-lang/language/issues/2509
-    - missing_code_block_language_in_doc_comment
-    - missing_whitespace_between_adjacent_strings
-    - no_adjacent_strings_in_list
-    - no_default_cases
-    - no_duplicate_case_values
-    - no_leading_underscores_for_library_prefixes
-    - no_leading_underscores_for_local_identifiers
-    - no_literal_bool_comparisons
-    - no_logic_in_create_state
-    - no_runtimeType_toString # DIFFERENT FROM FLUTTER/FLUTTER
-    - no_self_assignments
-    - no_wildcard_variable_uses
-    - non_constant_identifier_names
-    - noop_primitive_operations
-    - null_check_on_nullable_type_parameter
-    - null_closures
-    # - omit_local_variable_types # opposite of always_specify_types
-    # - one_member_abstracts # too many false positives
-    - only_throw_errors # this does get disabled in a few places where we have legacy code that uses strings et al
-    - overridden_fields
-    # - package_api_docs # Deprecated (https://github.com/dart-lang/linter/issues/5107)
-    - package_names
-    - package_prefixed_library_names
-    # - parameter_assignments # we do this commonly
-    - prefer_adjacent_string_concatenation
-    - prefer_asserts_in_initializer_lists
-    # - prefer_asserts_with_message # not required by flutter style
-    - prefer_collection_literals
-    - prefer_conditional_assignment
-    - prefer_const_constructors
-    - prefer_const_constructors_in_immutables
-    - prefer_const_declarations
-    - prefer_const_literals_to_create_immutables
-    # - prefer_constructors_over_static_methods # far too many false positives
-    - prefer_contains
-    # - prefer_double_quotes # opposite of prefer_single_quotes
-    # - prefer_expression_function_bodies # conflicts with https://github.com/flutter/flutter/blob/master/docs/contributing/Style-guide-for-Flutter-repo.md#consider-using--for-short-functions-and-methods
-    - prefer_final_fields
-    - prefer_final_in_for_each
-    - prefer_final_locals
-    # - prefer_final_parameters # adds too much verbosity
-    - prefer_for_elements_to_map_fromIterable
-    - prefer_foreach
-    - prefer_function_declarations_over_variables
-    - prefer_generic_function_type_aliases
-    - prefer_if_elements_to_conditional_expressions
-    - prefer_if_null_operators
-    - prefer_initializing_formals
-    - prefer_inlined_adds
-    # - prefer_int_literals # conflicts with https://github.com/flutter/flutter/blob/master/docs/contributing/Style-guide-for-Flutter-repo.md#use-double-literals-for-double-constants
-    - prefer_interpolation_to_compose_strings
-    - prefer_is_empty
-    - prefer_is_not_empty
-    - prefer_is_not_operator
-    - prefer_iterable_whereType
-    - prefer_mixin
-    # - prefer_null_aware_method_calls # "call()" is confusing to people new to the language since it's not documented anywhere
-    - prefer_null_aware_operators
+    # The public API of a published package must be documented.
+    - public_member_api_docs
+    # Missing awaits have caused production issues in plugins.
+    - unawaited_futures
     - prefer_relative_imports
     - prefer_single_quotes
-    - prefer_spread_collections
-    - prefer_typing_uninitialized_variables
-    - prefer_void_to_null
-    - provide_deprecation_message
-    - public_member_api_docs # DIFFERENT FROM FLUTTER/FLUTTER
-    - recursive_getters
-    # - require_trailing_commas # would be nice, but requires a lot of manual work: 10,000+ code locations would need to be reformatted by hand after bulk fix is applied
-    - secure_pubspec_urls
-    - sized_box_for_whitespace
-    - sized_box_shrink_expand
-    - slash_for_doc_comments
-    - sort_child_properties_last
-    - sort_constructors_first
-    - sort_pub_dependencies # DIFFERENT FROM FLUTTER/FLUTTER: Flutter's use case for not sorting does not apply to this repository.
-    - sort_unnamed_constructors_first
-    - test_types_in_equals
-    - throw_in_finally
-    - tighten_type_of_initializing_formals
-    # - type_annotate_public_apis # subset of always_specify_types
-    - type_init_formals
-    - type_literal_in_constant_pattern
-    - unawaited_futures # DIFFERENT FROM FLUTTER/FLUTTER: It's disabled there for "too many false positives"; that's not an issue here, and missing awaits have caused production issues in plugins.
-    - unnecessary_await_in_return
-    - unnecessary_brace_in_string_interps
-    - unnecessary_breaks
-    - unnecessary_const
-    - unnecessary_constructor_name
-    # - unnecessary_final # conflicts with prefer_final_locals
-    - unnecessary_getters_setters
-    # - unnecessary_lambdas # has false positives: https://github.com/dart-lang/linter/issues/498
-    - unnecessary_late
-    - unnecessary_library_directive
-    - unnecessary_new
-    - unnecessary_null_aware_assignments
-    - unnecessary_null_aware_operator_on_extension_on_nullable
-    - unnecessary_null_checks
-    - unnecessary_null_in_if_null_operators
-    - unnecessary_nullable_for_final_variable_declarations
-    - unnecessary_overrides
-    - unnecessary_parenthesis
-    # - unnecessary_raw_strings # what's "necessary" is a matter of opinion; consistency across strings can help readability more than this lint
-    - unnecessary_statements
-    - unnecessary_string_escapes
-    - unnecessary_string_interpolations
-    - unnecessary_this
-    - unnecessary_to_list_in_spreads
-    - unreachable_from_main
-    - unrelated_type_equality_checks
-    - use_build_context_synchronously
-    - use_colored_box
-    # - use_decorated_box # leads to bugs: DecoratedBox and Container are not equivalent (Container inserts extra padding)
-    - use_enums
-    - use_full_hex_values_for_flutter_colors
-    - use_function_type_syntax_for_parameters
-    - use_if_null_to_convert_nulls_to_bools
-    - use_is_even_rather_than_modulo
-    - use_key_in_widget_constructors
-    - use_late_for_private_fields_and_variables
-    - use_named_constants
-    - use_raw_strings
-    - use_rethrow_when_possible
-    - use_setters_to_change_properties
-    # - use_string_buffers # has false positives: https://github.com/dart-lang/sdk/issues/34182
-    - use_string_in_part_of_directives
-    - use_super_parameters
-    - use_test_throws_matchers
-    # - use_to_and_as_if_applicable # has false positives, so we prefer to catch this by code-review
-    - valid_regexps
-    - void_checks
+    - sort_pub_dependencies

example/android/gradle.properties

@@ -1,3 +1,7 @@
 org.gradle.jvmargs=-Xmx4G
 android.useAndroidX=true
 android.enableJetifier=true
+# This builtInKotlin flag was added automatically by Flutter migrator
+android.builtInKotlin=false
+# This newDsl flag was added automatically by Flutter migrator
+android.newDsl=false

example/android/settings.gradle

@@ -19,9 +19,8 @@ pluginManagement {
 // See https://github.com/flutter/flutter/blob/master/docs/ecosystem/Plugins-and-Packages-repository-structure.md#gradle-structure for more info.
 plugins {
     id "dev.flutter.flutter-plugin-loader" version "1.0.0"
-    id "com.android.application" version "8.2.1" apply false
+    id "com.android.application" version "8.6.0" apply false
     id "org.jetbrains.kotlin.android" version "1.9.0" apply false
-    id "com.google.cloud.artifactregistry.gradle-plugin" version "2.2.1"
 }
 
 include ":app"