Add golden render regression suite + resolve #123 docs (v1.0.12)#141
Merged
Conversation
Add committed golden tests that render representative Markdown documents (formatting/emphasis/blockquotes/lists, tables/task lists, and code blocks) and compare them against reference images, catching unintended changes to how content is laid out and styled. - Fonts (Roboto, MaterialIcons) are loaded from the Flutter SDK via FLUTTER_ROOT so the goldens show real glyphs rather than the Ahem test font. - Registered in test/all.dart so the aggregated suite runs them. - Like the existing image goldens they are platform-specific; they run in the local `flutter test` suite and are skipped on CI (whose Flutter `stable` channel is unpinned) to avoid flaky pixel-exact diffs when the toolchain drifts. Also notes in the CHANGELOG that the 1.0.11 README overhaul documented the previously undocumented onTapLink/styleSheet APIs, resolving #123. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014oVQtXCPb3bSLnL2eDwGrh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the golden-rendering effort real (committed regression tests) and records that the 1.0.11 README overhaul resolved #123.
Golden render tests
test/render_golden_test.dartrenders representative Markdown (formatting/emphasis/blockquotes/lists, tables/task lists, code) and compares against committed reference images undertest/assets/golden/render/.FLUTTER_ROOT) so goldens show real glyphs, not the Ahem test font.test/all.dart.stablechannel) to avoid flaky pixel-exact diffs. They run in the localflutter testsuite. Verified: passes locally, skips underGITHUB_ACTIONS=true. Pin the CI Flutter version to also verify them in CI.Docs / issues
onTapLink/styleSheetAPIs (resolves [Documentation]: Add samples, examples foronTapLink,styleSheets#123); the issue is now closed.Release
flutter analyzeclean; aggregatedflutter test test/all.dartgreen (golden tests run locally).🤖 Generated with Claude Code
https://claude.ai/code/session_014oVQtXCPb3bSLnL2eDwGrh