fix: ensure fork remote in setup_workspace before implementation push#201
Closed
danchild wants to merge 2 commits into
Closed
fix: ensure fork remote in setup_workspace before implementation push#201danchild wants to merge 2 commits into
danchild wants to merge 2 commits into
Conversation
…forge-sdlc#200) setup_workspace now calls get_or_create_fork during workspace setup when fork_owner/fork_repo aren't already in state, so the "fork" git remote exists before implement_bug_fix tries to push. Previously the fork was only ensured at PR creation time, causing push_to_fork to fall back to origin and fail with 403. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
danchild
force-pushed
the
fix/workspace-setup-ensure-fork-remote
branch
from
July 24, 2026 15:18
ae3eb51 to
a7ee831
Compare
…n test Wrap the GitHub client usage in try/finally so the HTTP client is always closed, even if an unexpected exception propagates. Add a dedicated test that verifies get_or_create_fork is called and fork_owner/fork_repo are persisted in state when not already present. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
danchild
marked this pull request as draft
July 24, 2026 19:52
This was referenced Jul 26, 2026
Collaborator
|
Superseded by #207 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #200
setup_workspacenow ensures the fork exists (viaget_or_create_fork) and adds the"fork"git remote during workspace setup, even whenfork_owner/fork_repoaren't already in workflow statefork_owner/fork_repoin returned state so downstream nodes have them availableimplement_bug_fixpushes before PR creation — causingpush_to_fork()to fall back toorigin(upstream) and fail with 403Test plan
test_workspace_setup.pytests pass with the newGitHubClientmock🤖 Generated with Claude Code