Mark Terminate() and a few more functions as noreturn#653
Merged
jodavies merged 2 commits intoform-dev:masterfrom Jan 23, 2026
Merged
Mark Terminate() and a few more functions as noreturn#653jodavies merged 2 commits intoform-dev:masterfrom
jodavies merged 2 commits intoform-dev:masterfrom
Conversation
Collaborator
|
I don't measure any performance difference here indeed, but that doesn't mean we shouldn't commit "performance best practice". I would say that |
Collaborator
This helps the compiler identify which code paths are taken rarely, and move them out of the way from hot paths, if not already.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This helps the compiler identify which code paths are taken rarely, and move them out of the way from hot paths. I'd expect a marginal (below 1%) performance improvement, if there was a benchmark suite. The
NORETURNmacro currently expands into__attribute__((noreturn)), which GCC and clang understand, or nothing, if the configure script figured out that the compiler doesn't know the syntax. In principle, C11 and C++11 both support a noreturn attribute (with different syntax), but I wasn't sure what is the minimum language version requirement.There's the issue of the Crash() function that crashes or not depending on the flags. I did not mark it as noreturn. I think that one deserves a separate consideration (i.e. why is it used in
sort.c?).