chore: invalidate all older sessions#110
Open
chronark wants to merge 7 commits intoformbricks:mainfrom
Open
Conversation
* fix: cache for enrollment * fix: cache * fix: cache * removed usage of octokit webhook * fixes * fix build --------- Co-authored-by: pandeymangg <anshuman.pandey9999@gmail.com>
A new cookie name is used for sessions, so all older sessions will no longer be valid. I could not really test this, cause there is a ton of required env variables, but I checked the source for nextauth and it should work ™️
|
@chronark is attempting to deploy a commit to the formbricks Team on Vercel. A member of the Team first needs to authorize it. |
|
Thank you for following the naming conventions for pull request titles! 🙏 |
Member
|
yeah I tried this but we then need to check for and handle invalid sessions which led to some secondary issues and I didn't have the time to handle that properly. Will look into it over the weekend |
Author
|
Old sessions shouldn't be an issue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A new cookie name is used for sessions, so all older sessions will no longer
be valid.
I could not really test this, cause there is a ton of required env variables,
but I checked the source for nextauth and it should work ™️
I didn't run prettier, cause it formatted a lot of unrelated files, which would pollute the PR