added Hermes setup for wechat-acp#5
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a new built-in ACP agent preset for Hermes and updates Node.js type definitions.
Changes:
- Add a
hermesentry toBUILT_IN_AGENTSso it can be selected via--agent hermes. - Bump
@types/nodedevDependency to^22.19.15(and update lockfile accordingly).
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/config.ts |
Registers the new hermes built-in agent preset. |
package.json |
Updates @types/node devDependency version. |
package-lock.json |
Locks @types/node to the updated version. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| export const BUILT_IN_AGENTS: Record<string, AgentPreset> = { | ||
| hermes: { | ||
| label: "Hermes Agent", | ||
| command: "hermes", | ||
| args: ["acp"], | ||
| description: "Hermes Agent ACP mode", | ||
| }, |
There was a problem hiding this comment.
Adding the new built-in hermes preset makes the user-facing preset list in README out of date (README.md currently lists copilot/claude/gemini/qwen/codex/opencode only). Please update the documentation so npx wechat-acp agents output matches the documented preset list.
| }, | ||
| "devDependencies": { | ||
| "@types/node": "^22.0.0", | ||
| "@types/node": "^22.19.15", |
There was a problem hiding this comment.
@types/node was bumped to v22 while engines.node is still ">=20.0.0". Using a newer Node type set than the minimum supported runtime can let TypeScript accept APIs that don't exist in Node 20, leading to runtime failures. Consider pinning @types/node to the minimum supported major (20) or raising the engines.node requirement accordingly.
| "@types/node": "^22.19.15", | |
| "@types/node": "^20.17.0", |
No description provided.