Remove duplicate :bigint entry and return nil for NULL Hive values#26
Closed
4ndypanda wants to merge 1 commit intoforward3d:masterfrom
Closed
Remove duplicate :bigint entry and return nil for NULL Hive values#264ndypanda wants to merge 1 commit intoforward3d:masterfrom
4ndypanda wants to merge 1 commit intoforward3d:masterfrom
Conversation
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We must merge #22 in order to see the benefit of this change.
If the results from Hive are in their correct Ruby types, then the current code will call
conversion_method ? value.send(conversion_method) : valueto determine what value is returned to the result set. However, if value is nil, then calling the conversion_method on nil will create default values such as 0 and empty string.