Rename table and Role classes to not conflict with existing classes#49
Open
ldm314 wants to merge 1 commit intoforward3d:masterfrom
Open
Rename table and Role classes to not conflict with existing classes#49ldm314 wants to merge 1 commit intoforward3d:masterfrom
ldm314 wants to merge 1 commit intoforward3d:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made a few changes. Renamed some of the thrift classes to not conflict with my own classes. Looks like it may address issue #20 and #47. I've not done extensive testing on these changes, nor do I know if this may have any side effects. My simple select statement test case worked for me.