Open
Conversation
- Add draw_circle method to RenderEnqueue Protocol and PygameSurfaceRenderer - Modify EntityRenderSystem to respect shape field for proper circle rendering - Implement realistic apple drawing with elliptical body, brown stem, and green leaf - Apples now render as realistic fruit instead of simple rectangles - Maintains backward compatibility for other shapes (square, rectangle) Closes #XXX
DeguShi
approved these changes
Dec 5, 2025
Collaborator
DeguShi
left a comment
DeguShi
left a comment
There was a problem hiding this comment.
Great addition, good job!
LeonardoIshida
approved these changes
Dec 7, 2025
Collaborator
LeonardoIshida
left a comment
LeonardoIshida
left a comment
There was a problem hiding this comment.
The apple looks great!
src/game/scenes/menu.py
Outdated
Comment on lines
170
to
180
| else: | ||
| try: | ||
| import pygame | ||
|
|
||
| if pygame.mixer.music.get_busy(): | ||
| pygame.mixer.music.stop() | ||
| from game.services.assets import GameAssets | ||
|
|
||
| GameAssets._current_music_track = None | ||
| except Exception: | ||
| pass |
Collaborator
There was a problem hiding this comment.
Does this need to be added to draw the new apple?
Author
There was a problem hiding this comment.
Done — the commits related to the menu audio have already been removed.
phprestes
requested changes
Dec 10, 2025
Collaborator
phprestes
left a comment
phprestes
left a comment
There was a problem hiding this comment.
Remove the commits about menu audio.
Author
|
Done — the commits related to the menu audio have already been removed. |
Collaborator
|
@JhonatanBarboza, thanks for keeping up with our requests and for your patience. Now, if you can just resolve the conflicts once more I will close the other two change requests and merge your contribution into the dev. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: implement realistic apple rendering with stem and leaf
Closes #447
