Conversation
ethanleelge
force-pushed
the
ethan_delete_comment
branch
5 times, most recently
from
8853033 to
3b8aaec
Compare
Contributor
Author
|
@dd-jy Please review this PR. |
ethanleelge
force-pushed
the
ethan_delete_comment
branch
from
3b8aaec to
38ff299
Compare
Contributor
Author
|
@dd-jy Please review this PR again.
|
dd-jy
requested changes
Mar 21, 2025
tox.ini
Outdated
| -r{toxinidir}/requirements-dev.txt | ||
|
|
||
| commands = | ||
| # Test - check PEP8 |
Contributor
There was a problem hiding this comment.
@ethanleelge
flake8 전체 코드에 대해서 적용되지 않은 것으로 보입니다.
기존에 작성된 아래 코드는 release 마커로 표시된 테스트 파일에 대해 flake8 검사를 실행합니다.
pytest -v --flake8 --ignore=script -m release
전체 소스코드에 대해 flake8 검사 실행하도록 수정해주시기 바랍니다.
Contributor
Author
There was a problem hiding this comment.
@dd-jy 수정했습니다. 근데 제대로 했는지 모르겠습니다. 확인부탁드리겠습니다.
ethanleelge
force-pushed
the
ethan_delete_comment
branch
10 times, most recently
from
0d151f8 to
439a52d
Compare
dd-jy
requested changes
Mar 24, 2025
Comment on lines
11
to
18
| exclude = | ||
| .git, | ||
| __pycache__, | ||
| doc, | ||
| resources, | ||
| .tox, | ||
| script, | ||
| site-packages |
Contributor
There was a problem hiding this comment.
@ethanleelge
release_flake8 적용될 때 flake8 옵션 적용될 수 있도록 해당 부분은 살려주시기 바랍니다.
tox.ini
Outdated
|
|
||
| commands = | ||
| pytest -v --flake8 --ignore=script -m release | ||
| pytest |
Signed-off-by: Ethan Lee <ethan.lee@lge.com>
ethanleelge
force-pushed
the
ethan_delete_comment
branch
from
439a52d to
a091d13
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Type of change