Conversation
dd-jy
reviewed
Jan 23, 2026
| _result_log, result_reports, output_extensions, formats, output_path, original_output_path = init( | ||
| path_to_find_bin, output_dir, formats, path_to_exclude) | ||
|
|
||
| total_bin_cnt = 0 |
Contributor
Author
There was a problem hiding this comment.
return 받는 변수 모두 사용됩니다.
아래 total_file_cnt는 사용되지 않아 제거하였습니다.
dd-jy
reviewed
Jan 23, 2026
| _result_log, compressed_list_txt, simple_bin_list_txt = init_simple(output_dir, PKG_NAME, start_time) | ||
| else: | ||
| _result_log, result_reports, output_extensions, formats = init( | ||
| _result_log, result_reports, output_extensions, formats, output_path, original_output_path = init( |
Contributor
There was a problem hiding this comment.
@bjk7119
이렇게되면 기존 output_path가 .fosslight_tmp로 변경되는데 로그말고 영향끼치는 부분 없나요?
Contributor
Author
There was a problem hiding this comment.
네 로그 말고는 결과파일 생성도 동일하게 되고 영향 끼치는 부분이 없으나
로그에도 original_output_path가 찍히는게 맞을 것 같아 추가 수정하였습니다.
dd-jy
approved these changes
Jan 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Type of change