Enhanced npm executable detection to improve reliability of package manager initialization

[woocheol-lge]

Description

Enhanced npm executable detection to improve reliability of package manager initialization

[coderabbitai]

📝 Walkthrough

Walkthrough

Updates to npm and yarn package manager modules: Npm resolves the npm executable path via shutil.which() instead of hard-coding it, and Yarn adds a warning log when the executable is unavailable before returning False.

Changes

Cohort / File(s)	Summary
Package Manager Executables src/fosslight_dependency/package_manager/Npm.py, src/fosslight_dependency/package_manager/Yarn.py	Npm.py now uses shutil.which("npm") to resolve the npm executable path in install_license_checker. Yarn.py adds warning logging in start_license_checker when Yarn is not available on the system.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

• feat(node): add automatic detection for local Node environment #301: Related changes to npm and yarn executable resolution using shutil.which() in the same package manager modules.

Suggested labels

chore

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check	❓ Inconclusive	The PR title emphasizes npm executable detection, but the actual changes involve using an explicit npm path in one file and adding a warning in Yarn. The title doesn't clearly reflect these specific, focused changes.	Consider a more precise title like 'Use explicit npm path for global license-checker installation' to accurately reflect the main change in Npm.py and mention the Yarn logging addition if relevant.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch ps_test

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}