Open
Conversation
Signed-off-by: Wonjae Park <j.wonjae.park@gmail.com>
Signed-off-by: Wonjae Park <j.wonjae.park@gmail.com>
Signed-off-by: Wonjae Park <j.wonjae.park@gmail.com>
JustinWonjaePark
force-pushed
the
dev_scancode_result_cleanup
branch
from
531764d to
8a5a2a9
Compare
dd-jy
reviewed
Apr 24, 2025
Comment on lines
+168
to
+174
| # Remove unknown-license-reference and leave only lge-proprietary | ||
| license_lower = [x.lower() for x in license_detected] | ||
| if ( | ||
| KEYWORD_UNKNOWN_LICENSE_REFERENCE.lower() in license_lower | ||
| and KEYWORD_LGE_PROPRIETARY.lower() in license_lower | ||
| ): | ||
| license_detected.remove(KEYWORD_UNKNOWN_LICENSE_REFERENCE) |
Contributor
There was a problem hiding this comment.
@JustinWonjaePark
다른 문구에서 검출되었다면 unknown 유지해야 하는 것이 아닐지 문의드립니다.
Contributor
There was a problem hiding this comment.
@JustinWonjaePark , KEYWORD_LGE_PROPRIETARY에 대해 제외하는 경우, License를 삭제하지 않고 UNKNOWN_LICENSE_REFERENCE 대신 KEYWORD_LGE_PROPRIETARY로 출력되게 변경이 필요합니다.
JustinWonjaePark
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Type of change