Skip to content

Input Redundancy Serializer does not check for empty snapshots #573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Riordan-DC wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Input Redundancy Serializer does not check for empty snapshots #573

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions addons/netfox/serializers/redundant-snapshot-serializer.gd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,9 @@ func write_for(peer: int, snapshots: Array[_Snapshot], properties: _PropertyPool
for snapshot in snapshots:
var serialized := _dense_serializer.write_for(peer, snapshot, properties)

if serialized.size() == 0:
continue

# Write size and snapshot
varuint.encode(serialized.size(), buffer)
buffer.put_data(serialized)
Expand All @@ -32,6 +35,10 @@ func read_from(peer: int, properties: _PropertyPool, buffer: StreamPeerBuffer, i
var snapshots := [] as Array[_Snapshot]
while buffer.get_available_bytes() > 0:
var snapshot_size := varuint.decode(buffer)

if snapshot_size == 0:
break

var snapshot_buffer := StreamPeerBuffer.new()
snapshot_buffer.data_array = buffer.get_partial_data(snapshot_size)[1]

Expand Down
Loading