Conversation
…uter chains As in the original implementation
chreekat
approved these changes
Mar 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-implement
gcaseR, by convertinggcase(which usesChains) to a new typeChainsR. This lookssimilar to the original implementation here, but without trying to do the recursion directly via
ChainsR(which seemsto be impossible with the current implementation).
The important commits are:
b79ced2 - Generalise
Chainsto have different return types in the inner and outer chains5a17f25 -
ChainsRis basically the same asChains, with the arguments in a different order48058f8 - Finally we can re-implement
gcaseRNote
This is undoubtedly more ergonomic, since it allows us to use partial application nicely:
However, this carries a slight performance impact. It will always be faster to use 'gcase', so if performance is critical in your use-case, use that. Then again, if performance is really critical, you'll always be better off writing your analysis function manually; or just pattern-matching directly.
Note to self
Update Changelog before merging.