Fix subscription UI crashes from invalid filter injection and null verifiers#2581
Open
utafrali wants to merge 1 commit intofrain-dev:mainfrom
Open
Conversation
|
|
Author
|
Closing — can't sign the CLA. Thanks anyway! |
Author
|
Apologies for closing this so abruptly. I jumped the gun on the CLA situation. I can get it signed now, so reopening the PR. Let me know if the changes still look good or need any updates. |
…ects and handle null verifier
utafrali
force-pushed
the
fix/issue-2580-bug-report-incoming-projects-critical-ui
branch
from
e76a7c2 to
cd469a2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2580. Fixes the crashes that happen when filters get invalid data or verifiers are null. Added proper test mocks for the services and improved null checks in the subscription component.