Open
Conversation
Collaborator
Author
|
Should I reintroduce some of the types (e.g. |
Collaborator
That's a good idea. We will immediately have some usage that will in small way test your changes. |
ppolesiuk
requested changes
Jul 2, 2025
Member
ppolesiuk
left a comment
There was a problem hiding this comment.
Most of the changes looks good. However, there are two things that need to be fixed:
- there is no possibility of accessing type-level operator from a module, e.g.
M.[+](if this will be fixed, theTBOpIDconstructor should not be necessary,TVarwill be sufficient) - we agreed that allowing definitions like
data A + B = ...instead ofdata [+] A B = ...are misleading: analogous construct on the level of expressions means something completely different (pattern matching against the constructor-level operator). This should be disallowed, at least by some warning.
Contributor
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #153