Simple profiling for the pipeline#326
Merged
ppolesiuk merged 4 commits intofram-lang:masterfrom Mar 14, 2026
Merged
Conversation
ppolesiuk
approved these changes
Mar 12, 2026
Member
ppolesiuk
left a comment
ppolesiuk
left a comment
There was a problem hiding this comment.
Generally I approve the changes. There are two minor issues that could be addressed.
There was a problem hiding this comment.
Pull request overview
Adds an opt-in pipeline profiling mode to help diagnose slow compilation/evaluation stages, aligned with Issue #293.
Changes:
- Introduces a
-timingsCLI flag to enable timing output. - Exposes a
Pipeline.timingsflag and implements per-stage timing measurement. - Wraps key pipeline stages (type/effect inference, lowering, checks, evaluation) with timing instrumentation.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/dbl.ml |
Adds the -timings command-line option to toggle profiling. |
src/Pipeline.mli |
Exposes the timings flag in the Pipeline module interface. |
src/Pipeline.ml |
Implements timing measurement and wraps pipeline stages to print durations. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#293
Add a
-timingsflag which prints timings of execution of each pipeline step.They are printed to stderr to separate them from the program's output.