Fix piped methods with named parameters#329
Merged
ppolesiuk merged 2 commits intofram-lang:masterfrom Mar 23, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes desugaring for piped method calls that use leading record arguments to pass named parameters (e.g., A >.foo {x=A}), aligning EMethodCall handling with the existing EApp behavior and adding a regression test for Issue #262.
Changes:
- Refactors application desugaring into a shared helper (
tr_apply) that properly collects leading record fields as explicit instantiations. - Updates
EMethodCalldesugaring to use the same named-parameter/instantiation path asEApp. - Adds a new
test/okregression test covering piped method calls with named parameters.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/DblParser/Desugar.ml |
Introduces tr_apply and routes both EApp and EMethodCall through it so leading record args are treated as explicit instantiations consistently. |
test/ok/ok0153_pipedMethodNamedParam.fram |
Adds a compile-only regression test reproducing A >.foo {x=A}. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#262
Fixed desugaring of piped method calls with named parameters.
A >.foo {x=A}used to fail, becauseEMethodCalldid not handle leading record arguments the same way asEApp.Added a regression test for this case.