Skip to content

chore(release): v1.0.2#4

Merged
frankieg33 merged 1 commit into
mainfrom
chore/release-v1.0.2
May 13, 2026
Merged

chore(release): v1.0.2#4
frankieg33 merged 1 commit into
mainfrom
chore/release-v1.0.2

Conversation

@frankieg33

Copy link
Copy Markdown
Owner

Summary

Cuts the v1.0.2 bug-fix release.

  • Bumps Cargo.toml / Cargo.lock to 1.0.2.
  • Adds the missing Win32_Graphics_Dwm windows-rs feature so the recently-added DwmGetWindowAttribute call compiles on the release target.

Changes since v1.0.1

  • Monitor: skip modal/owned windows + their parents (P0); HWND-level foreground guard; broader fullscreen detection; DWM cloaked filtering; monotonic-gap clamp on resume-from-sleep; action-log enriched with rule source + timeout; title redaction in info logs.
  • Config: fsync temp + parent dir on save.
  • Main: replace startup unwraps with fallible reads.
  • UI: force_repaint helper with a bounded redraw_tick sentinel — fixes the stale-framebuffer artifact when re-opening from the tray.
  • CI: pinned actions/checkout SHA, dropped mutable third-party actions from the release workflow, idempotent publish step.

After merge, push the v1.0.2 tag to trigger the release workflow.


Generated by Claude Code

Bug-fix release.

- Monitor: skip modal/owned windows and their parents (P0); HWND-level
  foreground guard; broader fullscreen detection; DWM cloaked filtering;
  monotonic-gap clamp for resume-from-sleep; action-log enriched with
  rule source + timeout; title redaction in info logs.
- Config: fsync temp + parent dir on save for durability.
- Main: replace startup unwraps with fallible reads.
- UI: force_repaint helper bumps a bounded redraw_tick sentinel so the
  Slint software renderer doesn't paint a stale framebuffer after a
  long hide-to-tray.
- CI: pinned actions/checkout SHA, dropped mutable third-party actions
  from the release workflow, idempotent publish step.
@frankieg33 frankieg33 merged commit 694bafc into main May 13, 2026
1 check passed

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the project version to 1.0.2 and adds the Win32_Graphics_Dwm feature to Cargo.toml. The reviewer noted that the addition of this feature should be accompanied by moving related DWM logic into src/winapi.rs to maintain the architectural requirement of isolating unsafe Win32 calls within that module.

Comment thread Cargo.toml
"Win32_System_Threading",
"Win32_System_ProcessStatus",
"Win32_Graphics_Gdi",
"Win32_Graphics_Dwm",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The Win32_Graphics_Dwm feature is added here to support DwmGetWindowAttribute (as mentioned in the PR description). However, this API call is not present in src/winapi.rs. Given that src/winapi.rs is documented as the module where all unsafe Win32 calls are isolated (line 2), using DWM APIs in other modules (such as src/monitor.rs) would violate this architectural rule. This makes the codebase harder to maintain and test, as the WindowApi trait is intended to be the sole abstraction for window operations. Consider moving any DWM-related logic into src/winapi.rs and exposing it through the WindowApi trait.

@frankieg33 frankieg33 deleted the chore/release-v1.0.2 branch May 13, 2026 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants