fix(winapi): add Win32_UI_Input_KeyboardAndMouse feature for IsWindowEnabled#7
Merged
Merged
Conversation
…IsWindowEnabled IsWindowEnabled moved to Win32::UI::Input::KeyboardAndMouse in windows 0.58, breaking compilation. Add the feature flag to Cargo.toml and import explicitly.
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
Owner
Author
|
@codex review |
Owner
Author
|
/gemini review |
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
IsWindowEnabledmoved toWin32::UI::Input::KeyboardAndMousein thewindows0.58 crate, causing a compile error on the updated dependency set pulled in from mainWin32_UI_Input_KeyboardAndMouseto the feature list inCargo.tomluse windows::Win32::UI::Input::KeyboardAndMouse::IsWindowEnabledimport inwinapi.rs(the wildcardWindowsAndMessaging::*no longer covers it)Test plan
cargo build --release --target x86_64-pc-windows-gnusucceeds with no errorscargo checkpasses on Linux (stub path compiles)cargo testpasses