Conversation
alopatindev
force-pushed
the
votes
branch
5 times, most recently
from
0f88f26 to
fab5634
Compare
alopatindev
force-pushed
the
votes
branch
4 times, most recently
from
bf6dcc2 to
731001f
Compare
Owner
|
@alopatindev thank you for this! I have very little time at the moment to review it, but I'll come back to it. I see you keep pushing commits, let me know when you think it's done |
Author
|
Awesome! It's done. |
Owner
|
Why do you keep force pushing? |
Author
|
That was a forgotten minor fix. I'm not going to force-push anything to this branch anymore, sorry if it's annoying or something. |
Owner
|
It's okay, I keep getting notifications but I asked because I didn't understand. When I click I see no changes in file changes and wondered why force push |
Author
|
I force-push to make history cleaner, however, not sure whether it's convenient to use, but GitHub shows diffs with Compare button for each force-push, like if they were normal commits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not sure whether you're interested in this feature, but anyway, this adds upvotes/likes (
+reactions) and downvotes/dislikes (-reactions). Other reactions are ignored in the vote rating (because considering states like-and at the same time 💩 is a bit complicated).If any user made several votes to a single message—all of the votes but the newest one will be ignored.
I didn't test it with the relays that don't support publishing reactions from free accounts.
Reactions are sent concurrently
Promise.allSettledto the relays (but perhaps they should be sent the same way as comments publishing is done right now).I didn't manage to make markup properly.
Feel free to make any changes if you find this PR valuable for merging.