chore(npm): Add support for npm and commonjs#7
chore(npm): Add support for npm and commonjs#7mattlewis92 wants to merge 3 commits intofrapontillo:developfrom
Conversation
|
@mattlewis92 do you still need this? If so, could you please add some tests to check that the module load happens correctly? Thanks. |
|
@frapontillo Yup I still need this, in order to do a test for it though I'll need to integrate a module bundler like webpack (as a dev dependency). Are you ok with this? |
|
Why would you need webpack? Can't you simply include commonjs as a devDep? |
|
Commonjs is a module format used by bundles such as browserify or webpack I.e require('module-name'); Its more of a technique rather than a library you install.
|
|
Yeah, but it would need the |
|
The |
|
Okay, thanks, let's see where this leads us! |
|
I've added a test for the module name, is that OK for you? |
I've added support for publishing to npm as well as requiring() with commonjs with tools like webpack, browserify etc.
After merging + whenever publishing a new release all you'll need to do is
npm publishLet me know if I missed anything.
Thanks!