Skip to content

fix(page-data-script): make translation actually callable as _(...) #745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
suparikoli wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

fix(page-data-script): make translation actually callable as _(...) #745

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9d9104e
fix(page-data-script): make translation actually callable as `_(...)`
suparikoli Aug 13, 2026
9772661
chore: trim oversized comments
surajshetty3416 Aug 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions builder/builder/tests/test_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,15 @@ def test_execute_script(self):
execute_script("data.sum = a + b", {"data": data, "a": 2, "b": 2}, "test.py")
self.assertEqual(data.sum, 4)

def test_execute_script_can_translate(self):
data = frappe._dict({})
execute_script('data.text = _("Supplier")', {"data": data}, "test.py")
self.assertEqual(data.text, "Supplier")

# the sandbox rejects `frappe._`, only the bare name works (#626)
with self.assertRaises(Exception):
execute_script('data.text = frappe._("Supplier")', {"data": data}, "test.py")

@patch("builder.utils.is_safe_exec_enabled", return_value=False)
@patch("frappe.utils.safe_exec.is_safe_exec_enabled", return_value=False)
def test_execute_script_with_enabled_server_script(self, *args):
Expand Down
2 changes: 2 additions & 0 deletions builder/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,6 +282,8 @@ def get_safer_globals():
as_json=frappe.as_json,
dict=safe_globals["dict"],
args=form_dict,
# must stay top-level: safe_exec's _getattr_ guard rejects `frappe._`
_=frappe._,
frappe=NamespaceDict(
db=NamespaceDict(
count=frappe.db.count,
Expand Down
Loading