fix(site): Skip rate limit on all dedicated server plans

[balamurali27]

Problem

Sites on a dedicated server must not be usage tracked. Site.get_plan_config() skipped the rate_limit config for those sites, but it decided by plan name:

UNLIMITED_PLANS = ["Unlimited", "Unlimited - Supported"]

Nine Site Plans have dedicated_server_plan set, and all of them have cpu_time_per_day > 0. The list covers two. The other seven get a real rate_limit written into site config on insert and on every plan change:

Unlimited - DigitalOcean, Unlimited - Hetzner, Unlimited - Supported - Hetzner, Unlimited - Low, Unlimited - Low - Hetzner, Unlimited - Low - Supported, Unlimited - Low - Supported - Hetzner

Site Plan is autoname: Prompt, so the name is free text. Each new region or tier drops out of the list without a sign. plan_title is no better — three of these plans share the title Large.

Change

Check the dedicated_server_plan flag instead of the name, and delete UNLIMITED_PLANS (this was its only use).

if plan and frappe.db.get_value("Site Plan", plan, "dedicated_server_plan"):
	# PERF: do not enable usage tracking on dedicated server sites.
	config["rate_limit"] = {}

Patch

New code only helps sites created or moved to a new plan after the deploy. The patch pushes rate_limit: {} to the dedicated server sites that already have a limit in their config, which is what a plan change to Unlimited already does today. frappe.rate_limiter.apply() does if rate_limit:, so an empty dict turns the limiter off. One agent job per affected site, failures are logged and skipped so an unreachable bench does not stop the migration.

Tests

Two tests on Site.get_plan_config() — a dedicated plan gets {}, a shared plan keeps the limit from cpu_time_per_day. create_test_plan gains a dedicated_server_plan argument.

bench --site test_frappe_cloud run-tests --app press --module press.press.doctype.site.test_site --test test_dedicated_server_plan_does_not_get_a_rate_limit
bench --site test_frappe_cloud run-tests --app press --module press.press.doctype.site.test_site --test test_shared_server_plan_gets_a_rate_limit_from_cpu_time
bench --site test_frappe_cloud run-tests --app press --module press.press.doctype.site_plan.test_site_plan

All pass.

🤖 Generated with Claude Code

[greptile-apps]

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

_{Reviews (4): Last reviewed commit: "Merge branch 'develop' into dedicated-si..." | Re-trigger Greptile}

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.88%. Comparing base (b0ac3ab) to head (7de0320).
⚠️ Report is 4 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff              @@
##           develop    #7266       +/-   ##
============================================
- Coverage    87.72%   59.88%   -27.84%     
============================================
  Files          129     1047      +918     
  Lines        22974    95548    +72574     
  Branches      1267     1268        +1     
============================================
+ Hits         20154    57221    +37067     
- Misses        2792    38299    +35507     
  Partials        28       28               

Flag	Coverage Δ
dashboard	87.72% <ø> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.