Refactor: Remove automatic "Mark as Read" from chat history fetch#36
Draft
Refactor: Remove automatic "Mark as Read" from chat history fetch#36
Conversation
…mous and improve MARK_AS_READ WebSocket handler Co-authored-by: fred-maina <150168105+fred-maina@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Refactor 'Mark as Read' logic for improved user control
Refactor: Remove automatic "Mark as Read" from chat history fetch
Dec 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Messages were automatically marked as read when fetching chat history via
getChatHistoryForAnonymous, preventing users from previewing chats without clearing unread counts. The frontend should control when messages are marked read via theMARK_AS_READWebSocket message.Changes
markMessagesAsRead()call, changed to@Transactional(readOnly = true)MARK_AS_READhandler extracts user from JWT and validates both email and chatId before processingmarkMessagesAsRead(String sessionId)overload that lacked user scopingTests
Added
ChatServiceTestandMessagingServiceTestto verify:getChatHistoryForAnonymousno longer callsmarkMessagesAsReadsetMessageAsReadcorrectly scopes updates to user + sessionOriginal prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.