chore: updating world map workshop prototype by danielfreire-dev · Pull Request #1136 · freeCodeCamp/CurriculumExpansion

danielfreire-dev · 2026-01-23T17:28:47Z

Checklist:

I have read freeCodeCamp's contribution guidelines.
My pull request has a descriptive title (not a vague title like Update index.md)

relates to #64629

…orldbank.org).

majestic-owl448 · 2026-01-23T17:40:34Z

what issue is this change related to?

jdwilkin4 · 2026-01-24T00:23:47Z

@danielfreire-dev

Are you part of Naomi's sprints? If so, please provide details on what this PR is in relation to so we better understand the context for these changes. Are you working on a lab or workshop?

danielfreire-dev · 2026-01-25T14:37:15Z

@jdwilkin4 @majestic-owl448

Yes, I am part of Naomi's Sprints.
This is an audit and update to the world map d3 project (freeCodeCamp/freeCodeCamp#64629).

I have updated to v7 (latest version).
Fixed any issues that I found.
Moved the tooltip closer to the user's mouse icon.
Did not see the need to update the JSON.
Updated the .csv file with 2025 data from the same source.

EDIT: added one more item

majestic-owl448

please mention the issue when you create a PR
please update the title so that it follows the docs https://contribute.freecodecamp.org/#/how-to-open-a-pull-request?id=prepare-a-good-pr-title

the csv data needs to go on the CDN repo (https://github.com/freeCodeCamp/cdn) and should be fetched (with d3 that is d3.json(url)

we are not able to have d3 as a minified version, this is the html for an other d3 project, you need to import `d3 in a similar way in your project

<!DOCTYPE html>
<html lang="en">
  <head>
    <meta charset="UTF-8" />
    <meta name="viewport" content="width=device-width, initial-scale=1.0" />
    <title>Build a Scatterplot Graph</title>
    <link rel="stylesheet" href="styles.css" />
    <script src="https://cdnjs.cloudflare.com/ajax/libs/d3/7.9.0/d3.min.js"></script>
  </head>
  <body>
    <script src="script.js"></script>
  </body>
</html>

because of how the editor works in the freeCodeCamp environment, the JS file name should be script.js and the CSS file name should be styles.css

…re and requests an online version of the csv file

.vscode/settings.json

jdwilkin4

Can you move this project over to the full stack folder? it will be easier to find all of these projects in one place later on.

https://github.com/freeCodeCamp/CurriculumExpansion/tree/main/fullstack-cert/d3-projects

…nt-end-libs' -> 'full-stack-certs'

jdwilkin4

It looks like you have a lot of extra files that don't need to be there.

You should only have three files.

An HTML file, CSS file and js file.

Once you resolve that, then we can review your project 👍🏾

jdwilkin4 · 2026-02-26T18:22:13Z

@danielfreire-dev

Did you need help resolve the extra files listed here?

danielfreire-dev · 2026-03-04T21:53:58Z

@jdwilkin4

I created a new PR to add these files to the CDN. I am waiting for its approval.

EDIT: grammar

jdwilkin4 · 2026-03-04T22:54:58Z

@danielfreire-dev

I left comments on your PR for the CDN repo.
Also, this PR still has 143 files changed

That will also need to be resolved before another review can be done

majestic-owl448 · 2026-03-05T18:51:05Z

@jdwilkin4 most of those where already existing files that got moved when the project folder was moved. Do you think they should be deleted? or the Lesson subfolder left where it was?

jdwilkin4 · 2026-03-05T19:06:10Z

Yeah, lets delete all of those extra files. Like the lessons files and folder and extra stuff like that.
That was added years ago back when part of adding the prototype also meant adding in individual lesson files.
But we are no longer doing that.

This PR should only contain the html, css and JS files.

jdwilkin4 · 2026-03-05T19:07:47Z

You should only have 3 files (index.html, styles.css. and script.js) in this PR because that is what will be used on learn.

majestic-owl448 · 2026-03-05T20:57:10Z

This PR should only contain the html, css and JS files.

so there should be an other PR deleting the Lessons folder? if deleted in this PR they will appear in this PR

jdwilkin4 · 2026-03-05T21:47:22Z

I pushed up some commit to reduce the file size from 143 to 10.

This will make it easier to review 👍🏾

@danielfreire-dev

Please pull down those latest changes. Once the CDN PR is resolved and merged in, then you will need to update your script.js to use the cdn link.

majestic-owl448

Thanks for the updates! A few things to address:

test.html should be removed, it looks like a leftover file.

script.js has a bug with D3 v7: d3.event was removed in v7, so the zoom won't work. The zoomed function needs to accept the event as a parameter:

function zoomed(event) {
  g.attr("transform", event.transform);
}

And the .on("zoom", zoomed) call is fine as-is.

A few cleanup items in script.js:

The // TODO: replace with freeCodeCamp CDN link comment at the top is stale, the path already uses the CDN
Remove the console.log statements for min/max population
Remove the commented-out // const low and // const high lines

tooltip fixed. added population data for 2025 from the same source (w…

cfe098b

…orldbank.org).

jdwilkin4 added the awaiting update label Jan 24, 2026

majestic-owl448 reviewed Jan 25, 2026

View reviewed changes

danielfreire-dev changed the title ~~tooltip fixed. added population data for 2025 from the same source (w…~~ chore (D3 update): updating D3 to newest version (v7), including any necessary code updates #64629 Jan 26, 2026

danielfreire-dev changed the title ~~chore (D3 update): updating D3 to newest version (v7), including any necessary code updates #64629~~ chore (D3 update): updating D3 to newest version (v7), including any necessary code updates Jan 26, 2026

danielfreire-dev changed the title ~~chore (D3 update): updating D3 to newest version (v7), including any necessary code updates~~ chore: (D3 update): updating D3 to newest version (v7), including any necessary code updates Jan 26, 2026

danielfreire-dev changed the title ~~chore: (D3 update): updating D3 to newest version (v7), including any necessary code updates~~ chore: updating D3 to newest version (v7), including any necessary code updates Jan 26, 2026

changed .js file name, css file name, uses cdn version of d3(cloudfla…

1eeb7ce

…re and requests an online version of the csv file

danielfreire-dev requested a review from majestic-owl448 January 26, 2026 20:35

danielfreire-dev mentioned this pull request Jan 26, 2026

feat: adds new world pop csv file for d3 project freeCodeCamp/cdn#373

Merged

2 tasks

majestic-owl448 reviewed Jan 26, 2026

View reviewed changes

.vscode/settings.json Outdated Show resolved Hide resolved

removed .vscode/

0cb5861

jdwilkin4 changed the title ~~chore: updating D3 to newest version (v7), including any necessary code updates~~ chore: updating world map workshop prototype Jan 28, 2026

jdwilkin4 added workshop status: waiting review full stack cert and removed awaiting update labels Jan 28, 2026

jdwilkin4 reviewed Feb 2, 2026

View reviewed changes

danielfreire-dev added 2 commits February 7, 2026 16:27

updated .css file name. fetching data from cdn now. moved course 'fro…

933daf6

…nt-end-libs' -> 'full-stack-certs'

updated .css file name. fetching data from cdn now. moved course 'fro…

36028f1

…nt-end-libs' -> 'full-stack-certs'

majestic-owl448 added this to Naomi's Contribution Sprints Feb 12, 2026

github-project-automation bot moved this to Backlog in Naomi's Contribution Sprints Feb 12, 2026

majestic-owl448 moved this from Backlog to In progress in Naomi's Contribution Sprints Feb 12, 2026

majestic-owl448 moved this from In progress to In review in Naomi's Contribution Sprints Feb 12, 2026

jdwilkin4 reviewed Feb 13, 2026

View reviewed changes

jdwilkin4 added awaiting update and removed status: waiting review labels Feb 13, 2026

jdwilkin4 added 2 commits March 5, 2026 13:40

refactor: move old folder

686160e

fix: restoring old files

3a00d4b

updated links for fCC's CDN

995bd1d

majestic-owl448 added status: waiting review and removed awaiting update labels Mar 16, 2026

majestic-owl448 reviewed Mar 16, 2026

View reviewed changes

Uh oh!

Conversation

danielfreire-dev commented Jan 23, 2026 • edited by jdwilkin4 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

majestic-owl448 commented Jan 23, 2026

Uh oh!

jdwilkin4 commented Jan 24, 2026

Uh oh!

danielfreire-dev commented Jan 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

majestic-owl448 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jdwilkin4 left a comment

Choose a reason for hiding this comment

Uh oh!

jdwilkin4 left a comment

Choose a reason for hiding this comment

Uh oh!

jdwilkin4 commented Feb 26, 2026

Uh oh!

danielfreire-dev commented Mar 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jdwilkin4 commented Mar 4, 2026

Uh oh!

majestic-owl448 commented Mar 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jdwilkin4 commented Mar 5, 2026

Uh oh!

jdwilkin4 commented Mar 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

majestic-owl448 commented Mar 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jdwilkin4 commented Mar 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

majestic-owl448 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

danielfreire-dev commented Jan 23, 2026 •

edited by jdwilkin4

Loading

danielfreire-dev commented Jan 25, 2026 •

edited

Loading

danielfreire-dev commented Mar 4, 2026 •

edited

Loading

majestic-owl448 commented Mar 5, 2026 •

edited

Loading

jdwilkin4 commented Mar 5, 2026 •

edited

Loading

majestic-owl448 commented Mar 5, 2026 •

edited

Loading

jdwilkin4 commented Mar 5, 2026 •

edited

Loading