Test Authentication against FireBase#28
Closed
awinabi wants to merge 1 commit intofreesendmails:masterfrom
awinabi:authentication-specs
Closed
Test Authentication against FireBase#28awinabi wants to merge 1 commit intofreesendmails:masterfrom awinabi:authentication-specs
awinabi wants to merge 1 commit intofreesendmails:masterfrom
awinabi:authentication-specs
Conversation
* Use VCR responses from Firebase for authentication flows
Contributor
Author
|
This is complete and ready for review. Thanks! |
Member
|
@diogopms Could you review this? |
|
|
||
| def firebase_find_users(email) | ||
| if firebase_users && firebase_users.body.present? | ||
| firebase_users.body.values.select {|u| u['email'] == email} |
There was a problem hiding this comment.
we can use firebase_user_emails function here and then filter email. Additional check can be prevented
Contributor
Author
There was a problem hiding this comment.
@prashuchaudhary I want the whole user JSON here, because I need to compare various other fields in the User hash in the specs. Using firebase_user_emails will give me just the email.
diogopms
approved these changes
Oct 14, 2019
diogopms
suggested changes
Oct 14, 2019
Contributor
diogopms
left a comment
There was a problem hiding this comment.
Can you rebase this code?
Contributor
Author
|
@diogopms Have not looked at this for a while now. Let me rebase and check if the specs are still passing. |
Contributor
|
👍 Great |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the sample code that contains specs that I'm planning to implement for the issues #11, #12, #13, #14. We can use https://github.com/vcr/vcr for canned responses from FireBase to test the various authentication flows.
@grassiricardo Does this sound good?